You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by to...@apache.org on 2018/08/09 21:48:10 UTC

[4/9] impala git commit: IMPALA-7361: Fix flakiness in test_heterogeneous_proc_mem_limit

IMPALA-7361: Fix flakiness in test_heterogeneous_proc_mem_limit

This patch fixes flakiness in test_heterogeneous_proc_mem_limit wherein
one of the fragments on a host from a previous query lingers and holds
on to resources which causes the next query to fail the test since it
expects the cluster to be idle at that point.

Change-Id: I3e5c9b0c6a99d7157640c02e6b3c808b4ae9e73c
Reviewed-on: http://gerrit.cloudera.org:8080/11166
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


Project: http://git-wip-us.apache.org/repos/asf/impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/impala/commit/5cb956e3
Tree: http://git-wip-us.apache.org/repos/asf/impala/tree/5cb956e3
Diff: http://git-wip-us.apache.org/repos/asf/impala/diff/5cb956e3

Branch: refs/heads/master
Commit: 5cb956e3fd86ba6f9b49a273737f46467b4a1936
Parents: 2ced56c
Author: Bikramjeet Vig <bi...@cloudera.com>
Authored: Wed Aug 8 11:19:15 2018 -0700
Committer: Impala Public Jenkins <im...@cloudera.com>
Committed: Thu Aug 9 03:04:33 2018 +0000

----------------------------------------------------------------------
 tests/custom_cluster/test_admission_controller.py | 3 +++
 1 file changed, 3 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/impala/blob/5cb956e3/tests/custom_cluster/test_admission_controller.py
----------------------------------------------------------------------
diff --git a/tests/custom_cluster/test_admission_controller.py b/tests/custom_cluster/test_admission_controller.py
index 32fd971..4b8974a 100644
--- a/tests/custom_cluster/test_admission_controller.py
+++ b/tests/custom_cluster/test_admission_controller.py
@@ -500,6 +500,9 @@ class TestAdmissionController(TestAdmissionControllerBase, HS2TestSuite):
           "node is greater than process mem limit 2.00 GB of \S+", str(e)), str(e)
     # Exercise queuing checks in admission controller.
     try:
+      # Wait for previous queries to finish to avoid flakiness.
+      for impalad in self.cluster.impalads:
+        impalad.service.wait_for_metric_value("impala-server.num-fragments-in-flight", 0)
       impalad_with_2g_mem = self.cluster.impalads[2].service.create_beeswax_client()
       impalad_with_2g_mem.set_configuration_option('mem_limit', '1G')
       impalad_with_2g_mem.execute_async("select sleep(1000)")