You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/04/26 08:02:17 UTC
[GitHub] [spark] MaxGekk commented on pull request #36351: [SPARK-39015][SQL] Remove the usage of toSQLValue(v) without an explicit type
MaxGekk commented on PR #36351:
URL: https://github.com/apache/spark/pull/36351#issuecomment-1109479285
> Literal(v) is intended to be used from end-users so it cannot handle our internal types such as UTF8String and ArrayBasedMapData.
When I added two methods `toSQLValue()`, I supposed to use:
- def toSQLValue(v: Any, t: DataType) with internal value
- def toSQLValue(v: Any): String w/ external like String
If you need to pass somewhere an internal value, just use the first method. Why do you need to remove the second one, I didn't get.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org