You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Dongsheng Song <do...@apache.org> on 2011/03/10 09:07:08 UTC
[PATCH] Make translation status report message threaded
[[[
Make translation status report message threaded.
* tools/po/l10n-report.py: Add "In-Reply-To:" and "References:" fields
to the translation status report message, so we can view mail more
clearly.
]]]
oracle@vc:~/vcs/svn/subversion/trunk/tools/po$ svn diff .
Index: l10n-report.py
===================================================================
--- l10n-report.py (revision 1080141)
+++ l10n-report.py (working copy)
@@ -43,6 +43,7 @@
FROM_ADDRESS = "Subversion Translation Status <no...@subversion.apache.org>"
LIST_ADDRESS = "dev@subversion.apache.org"
SUBJECT_TEMPLATE = "[l10n] Translation status report for %s r%s"
+MAIL_THREAD_ID = '<tr...@subversion.apache.org>'
def _rev():
dollar = "$Revision$"
@@ -204,6 +205,8 @@
msg["X-Mailer"] = "l10n-report.py r%s" % _rev()
msg["Reply-To"] = LIST_ADDRESS
msg["Mail-Followup-To"] = LIST_ADDRESS
+ msg["In-Reply-To"] = MAIL_THREAD_ID % (branch_name.replace('/', '_'))
+ msg["References"] = msg["In-Reply-To"]
# http://www.iana.org/assignments/auto-submitted-keywords/auto-submitted-keywords.xhtml
msg["Auto-Submitted"] = 'auto-generated'
msg.set_type("text/plain")
--
Dongsheng
Re: [PATCH] Make translation status report message threaded
Posted by Dongsheng Song <do...@apache.org>.
On Mon, Mar 28, 2011 at 08:24, Gavin Baumanis <ga...@thespidernet.com>wrote:
> Hi Dongsheng,
>
> Just checking to see if yo have made this commit or if you were waiting
> form something more?
> If something else is required, is it something I can assist with?
>
> Gavin.
>
Please see the following svn log output:
------------------------------------------------------------------------
r1080426 | dongsheng | 2011-03-11 10:15:30 +0800 (Fri, 11 Mar 2011) | 8
lines
Make translation status report message threaded.
Approved by: philip
* tools/po/l10n-report.py: Add "In-Reply-To:" and "References:" fields
to the translation status report message, so we can view mail more
clearly.
------------------------------------------------------------------------
--
Dongsheng
Re: [PATCH] Make translation status report message threaded
Posted by Gavin Baumanis <ga...@thespidernet.com>.
Hi Dongsheng,
Just checking to see if yo have made this commit or if you were waiting form something more?
If something else is required, is it something I can assist with?
Gavin.
On 11/03/2011, at 12:08 AM, Philip Martin wrote:
> Dongsheng Song <do...@apache.org> writes:
>
>> On Thu, Mar 10, 2011 at 17:54, Philip Martin <ph...@wandisco.com> wrote:
>>> In-Reply-To and References would usually contain message-ids, what you
>>> are inserting is a fake message-id -- no email has it. A MUA won't find
>>> the referenced message-id, it doesn't exist, but will see multiple
>>> messages that refer to that id. I guess lots of MUAs will react by
>>> grouping those messages together. Is that what you want to achieve?
>>
>> This is exactly what I needed.
>
> I think that's a reasonable, +1 to commit.
>
> --
> Philip
Re: [PATCH] Make translation status report message threaded
Posted by Philip Martin <ph...@wandisco.com>.
Dongsheng Song <do...@apache.org> writes:
> On Thu, Mar 10, 2011 at 17:54, Philip Martin <ph...@wandisco.com> wrote:
>> In-Reply-To and References would usually contain message-ids, what you
>> are inserting is a fake message-id -- no email has it. A MUA won't find
>> the referenced message-id, it doesn't exist, but will see multiple
>> messages that refer to that id. I guess lots of MUAs will react by
>> grouping those messages together. Is that what you want to achieve?
>
> This is exactly what I needed.
I think that's a reasonable, +1 to commit.
--
Philip
Re: [PATCH] Make translation status report message threaded
Posted by Dongsheng Song <do...@apache.org>.
On Thu, Mar 10, 2011 at 17:54, Philip Martin <ph...@wandisco.com> wrote:
> Dongsheng Song <do...@apache.org> writes:
>
>> Index: l10n-report.py
>> ===================================================================
>> --- l10n-report.py (revision 1080141)
>> +++ l10n-report.py (working copy)
>> @@ -43,6 +43,7 @@
>> FROM_ADDRESS = "Subversion Translation Status <no...@subversion.apache.org>"
>> LIST_ADDRESS = "dev@subversion.apache.org"
>> SUBJECT_TEMPLATE = "[l10n] Translation status report for %s r%s"
>> +MAIL_THREAD_ID = '<tr...@subversion.apache.org>'
>>
>> def _rev():
>> dollar = "$Revision$"
>> @@ -204,6 +205,8 @@
>> msg["X-Mailer"] = "l10n-report.py r%s" % _rev()
>> msg["Reply-To"] = LIST_ADDRESS
>> msg["Mail-Followup-To"] = LIST_ADDRESS
>> + msg["In-Reply-To"] = MAIL_THREAD_ID % (branch_name.replace('/', '_'))
>> + msg["References"] = msg["In-Reply-To"]
>> # http://www.iana.org/assignments/auto-submitted-keywords/auto-submitted-keywords.xhtml
>> msg["Auto-Submitted"] = 'auto-generated'
>> msg.set_type("text/plain")
>
> In-Reply-To and References would usually contain message-ids, what you
> are inserting is a fake message-id -- no email has it. A MUA won't find
> the referenced message-id, it doesn't exist, but will see multiple
> messages that refer to that id. I guess lots of MUAs will react by
> grouping those messages together. Is that what you want to achieve?
>
> --
> Philip
>
Do you mean the following behavior ?
http://people.apache.org/~dongsheng/image/public/mail_report_threaded.png
This is exactly what I needed.
--
Dongsheng
Re: [PATCH] Make translation status report message threaded
Posted by Philip Martin <ph...@wandisco.com>.
Dongsheng Song <do...@apache.org> writes:
> Index: l10n-report.py
> ===================================================================
> --- l10n-report.py (revision 1080141)
> +++ l10n-report.py (working copy)
> @@ -43,6 +43,7 @@
> FROM_ADDRESS = "Subversion Translation Status <no...@subversion.apache.org>"
> LIST_ADDRESS = "dev@subversion.apache.org"
> SUBJECT_TEMPLATE = "[l10n] Translation status report for %s r%s"
> +MAIL_THREAD_ID = '<tr...@subversion.apache.org>'
>
> def _rev():
> dollar = "$Revision$"
> @@ -204,6 +205,8 @@
> msg["X-Mailer"] = "l10n-report.py r%s" % _rev()
> msg["Reply-To"] = LIST_ADDRESS
> msg["Mail-Followup-To"] = LIST_ADDRESS
> + msg["In-Reply-To"] = MAIL_THREAD_ID % (branch_name.replace('/', '_'))
> + msg["References"] = msg["In-Reply-To"]
> # http://www.iana.org/assignments/auto-submitted-keywords/auto-submitted-keywords.xhtml
> msg["Auto-Submitted"] = 'auto-generated'
> msg.set_type("text/plain")
In-Reply-To and References would usually contain message-ids, what you
are inserting is a fake message-id -- no email has it. A MUA won't find
the referenced message-id, it doesn't exist, but will see multiple
messages that refer to that id. I guess lots of MUAs will react by
grouping those messages together. Is that what you want to achieve?
--
Philip