You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metron.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/07/27 13:53:00 UTC
[jira] [Commented] (METRON-1069) Ambari MPack documentation around
development strategies
[ https://issues.apache.org/jira/browse/METRON-1069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16103229#comment-16103229 ]
ASF GitHub Bot commented on METRON-1069:
----------------------------------------
GitHub user justinleet opened a pull request:
https://github.com/apache/metron/pull/673
METRON-1069: Ambari MPack documentation around development strategies
## Contributor Comments
First cut at documentation around actually making changes to the management pack. I haven't touched this in awhile, so I'd definitely like feedback on things as well as anything else to ease the experience of diving into the mpack.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.
Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/justinleet/metron ambari_readme
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/673.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #673
----
commit b4c752e504c49a0d7c6f8eb2944d4919896b67e2
Author: justinjleet <ju...@gmail.com>
Date: 2017-07-27T13:35:22Z
Adding initial cut at the readme
----
> Ambari MPack documentation around development strategies
> --------------------------------------------------------
>
> Key: METRON-1069
> URL: https://issues.apache.org/jira/browse/METRON-1069
> Project: Metron
> Issue Type: Improvement
> Reporter: Justin Leet
> Assignee: Justin Leet
>
> The Mpack is already hard enough to develop for if you know kind of what you're doing. If you have no idea, right now we don't give any help.
> The minimum this should cover to start is
> How do I add properties?
> How do I use properties in the existing services?
> How do I tell if something has gone wrong?
> How do I tell where it went wrong?
> How do I cycle more quickly than rebuilding the dev VM entirely?
> In the future, we should build some scripting around this. E.g. to automatically clean and redeploy the mpack scripts and configs.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)