You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by traflm <gi...@git.apache.org> on 2018/04/25 03:21:58 UTC
[GitHub] trafodion pull request #1540: [TRAFODION-2953] initial implementation
GitHub user traflm opened a pull request:
https://github.com/apache/trafodion/pull/1540
[TRAFODION-2953] initial implementation
This is the very first code drop for TRAFODION-2953, the major purpose is to get feedback to see if the design is OK and shall we continue with this effort or not.
Please check https://issues.apache.org/jira/browse/TRAFODION-2953, I attached a design document there.
This PR contains initial prototype of the design. It still has a major code-refactor to do, but I would like to hear from community first, before I spend more time on it, in case there are something fundamentally wrong.
The major change for this prototype code is to add a new PartitionFunction, instead of modifying the SinglePartitionPartitioningFunction directly. I will inherit a new SinglePartitionWithSmallTablePartitioningFunction from SinglePartitionPartitioningFunction next.
One can check the TEST035 to get a demo of how it works.
There are many other tasks following this initial code drop. For example, index/alter/create-super-table etc.
The major idea to support this is to add a new SYSTEM column _TBLNM_, so in a single Region, rows belong to different tables can be distinguished. When doing IUDS, always add predicate _TBLNM_ = 'theNameOfTheTable' to filter out the correct rows.
Please help to review and let me know your comments!
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/traflm/trafodion TRAFODION-2953-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafodion/pull/1540.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1540
----
commit 04123ad4168fbd7305caf37d5c8f02deb6eafa07
Author: Liu Ming <ov...@...>
Date: 2018-04-24T21:28:26Z
AFODION-2953] initial implementation
----
---
[GitHub] trafodion pull request #1540: [TRAFODION-2953] initial implementation of sma...
Posted by traflm <gi...@git.apache.org>.
GitHub user traflm reopened a pull request:
https://github.com/apache/trafodion/pull/1540
[TRAFODION-2953] initial implementation of small table in one Hbase Region
This is the very first code drop for TRAFODION-2953, the major purpose is to get feedback to see if the design is OK and shall we continue with this effort or not.
Please check https://issues.apache.org/jira/browse/TRAFODION-2953, I attached a design document there.
This PR contains initial prototype of the design. It still has a major code-refactor to do, but I would like to hear from community first, before I spend more time on it, in case there are something fundamentally wrong.
The major change for this prototype code is to add a new PartitionFunction, instead of modifying the SinglePartitionPartitioningFunction directly. I will inherit a new SinglePartitionWithSmallTablePartitioningFunction from SinglePartitionPartitioningFunction next.
One can check the TEST035 to get a demo of how it works.
There are many other tasks following this initial code drop. For example, index/alter/create-super-table etc.
The major idea to support this is to add a new SYSTEM column _TBLNM_, so in a single Region, rows belong to different tables can be distinguished. When doing IUDS, always add predicate _TBLNM_ = 'theNameOfTheTable' to filter out the correct rows.
Please help to review and let me know your comments!
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/traflm/trafodion TRAFODION-2953-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafodion/pull/1540.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1540
----
commit 04123ad4168fbd7305caf37d5c8f02deb6eafa07
Author: Liu Ming <ov...@...>
Date: 2018-04-24T21:28:26Z
AFODION-2953] initial implementation
commit c195c6fe23a214cad3b8db3359c19b282ac7a5c1
Author: Liu Ming <ov...@...>
Date: 2018-04-24T22:14:22Z
[TRAFODION-2953] first code drop for small table in one HBase Region
----
---
[GitHub] trafodion pull request #1540: [TRAFODION-2953] initial implementation of sma...
Posted by traflm <gi...@git.apache.org>.
GitHub user traflm reopened a pull request:
https://github.com/apache/trafodion/pull/1540
[TRAFODION-2953] initial implementation of small table in one Hbase Region
This is the very first code drop for TRAFODION-2953, the major purpose is to get feedback to see if the design is OK and shall we continue with this effort or not.
Please check https://issues.apache.org/jira/browse/TRAFODION-2953, I attached a design document there.
This PR contains initial prototype of the design. It still has a major code-refactor to do, but I would like to hear from community first, before I spend more time on it, in case there are something fundamentally wrong.
The major code-refactor I mentioned above is for this prototype code is to add a new PartitionFunction, instead of modifying the SinglePartitionPartitioningFunction directly. I will inherit a new SinglePartitionWithSmallTablePartitioningFunction from SinglePartitionPartitioningFunction next.
One can check the TEST035 to get a demo of how it works.
There are many other tasks following this initial code drop. For example, index/alter/create-super-table etc.
The major idea to support this is to add a new SYSTEM column _TBLNM_, so in a single Region, rows belong to different tables can be distinguished. When doing IUDS, always add predicate _TBLNM_ = 'theNameOfTheTable' to filter out the correct rows.
Please help to review and let me know your comments, many thanks.
The requirement is strong. In some use cases, there must be many small tables.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/traflm/trafodion TRAFODION-2953-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafodion/pull/1540.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1540
----
commit 04123ad4168fbd7305caf37d5c8f02deb6eafa07
Author: Liu Ming <ov...@...>
Date: 2018-04-24T21:28:26Z
AFODION-2953] initial implementation
commit c195c6fe23a214cad3b8db3359c19b282ac7a5c1
Author: Liu Ming <ov...@...>
Date: 2018-04-24T22:14:22Z
[TRAFODION-2953] first code drop for small table in one HBase Region
----
---
[GitHub] trafodion pull request #1540: [TRAFODION-2953] initial implementation of sma...
Posted by traflm <gi...@git.apache.org>.
Github user traflm closed the pull request at:
https://github.com/apache/trafodion/pull/1540
---
[GitHub] trafodion pull request #1540: [TRAFODION-2953] initial implementation of sma...
Posted by traflm <gi...@git.apache.org>.
Github user traflm closed the pull request at:
https://github.com/apache/trafodion/pull/1540
---
[GitHub] trafodion pull request #1540: [TRAFODION-2953] initial implementation of sma...
Posted by traflm <gi...@git.apache.org>.
Github user traflm commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1540#discussion_r183936345
--- Diff: core/sql/regress/tools/sbdefs ---
@@ -22,7 +22,7 @@
-- defs included during seabase regr run
#ifdef SEABASE_REGRESS
-cqd mode_seabase 'ON';
+--cqd mode_seabase 'ON';
--- End diff --
typo, will fix this in next commit. Sorry
---