You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@guacamole.apache.org by "Nick Couchman (Jira)" <ji...@apache.org> on 2020/04/23 14:02:00 UTC
[jira] [Commented] (GUACAMOLE-1047) Notify connecting client on
unrecognized connection ID
[ https://issues.apache.org/jira/browse/GUACAMOLE-1047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090636#comment-17090636 ]
Nick Couchman commented on GUACAMOLE-1047:
------------------------------------------
[~holograph]: Thanks, and a pull request would be great!
> Notify connecting client on unrecognized connection ID
> ------------------------------------------------------
>
> Key: GUACAMOLE-1047
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-1047
> Project: Guacamole
> Issue Type: Improvement
> Components: guacd
> Reporter: Tomer Gabel
> Priority: Minor
>
> When a client starts the handshake with an invalid connection ID (i.e. sends a {{select}} with an argument prefixed with {{$}}), guacd immediately drops the connection. Although this is logged on the server said, the client is completely unaware of what's going on.
> Beyond being just plain rude, this makes error reporting and handling difficult in some cases. The protocol specifically allows an {{error}} command to be sent by the server during the handshake, which would be very handy in this case; please expect a pull request addressing this in guacd, hopefully it meets the contribution guidelines :)
> (Incidentally, the handshake implementation in guacamole-common's tunneling code does not actually handle error commands, expect a separate issue + pull request to address that.)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)