You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by GitBox <gi...@apache.org> on 2022/09/20 07:23:31 UTC
[GitHub] [orc] deshanxiao opened a new pull request, #1258: ORC-1278: Update cmake docs version to 3.12
deshanxiao opened a new pull request, #1258:
URL: https://github.com/apache/orc/pull/1258
### What changes were proposed in this pull request?
This PR aims to add a cmake build version in [README.md](https://github.com/apache/orc/blob/main/README.md)
### Why are the changes needed?
[add_compile_definitions ](https://cmake.org/cmake/help/latest/command/add_compile_definitions.html)only supprt cmake 3.12+. We can update the docs [README.md](https://github.com/apache/orc/blob/main/README.md)
In ubuntu 18.04:
> sudo apt install cmake
> make ..
we will get an error:
CMake Error at CMakeLists.txt:147 (add_compile_definitions):
Unknown CMake command "add_compile_definitions".
### How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] guiyanakuang commented on pull request #1258: ORC-1278: Update cmake docs version to 3.12
Posted by GitBox <gi...@apache.org>.
guiyanakuang commented on PR #1258:
URL: https://github.com/apache/orc/pull/1258#issuecomment-1253372760
Merged to main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] guiyanakuang merged pull request #1258: ORC-1278: Update cmake docs version to 3.12
Posted by GitBox <gi...@apache.org>.
guiyanakuang merged PR #1258:
URL: https://github.com/apache/orc/pull/1258
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] deshanxiao commented on pull request #1258: ORC-1278: Update cmake docs version to 3.12
Posted by GitBox <gi...@apache.org>.
deshanxiao commented on PR #1258:
URL: https://github.com/apache/orc/pull/1258#issuecomment-1251947357
CC @dongjoon-hyun @williamhyun and @guiyanakuang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1258: ORC-1278: Update cmake docs version to 3.12
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #1258:
URL: https://github.com/apache/orc/pull/1258#issuecomment-1254527990
+1 for @wgtmac 's suggestion! Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1258: ORC-1278: Update cmake docs version to 3.12
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #1258:
URL: https://github.com/apache/orc/pull/1258#issuecomment-1253971151
To be clear, this is for Apache ORC 1.9 whose release date is `September 15, 2023`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] deshanxiao commented on pull request #1258: ORC-1278: Update cmake docs version to 3.12
Posted by GitBox <gi...@apache.org>.
deshanxiao commented on PR #1258:
URL: https://github.com/apache/orc/pull/1258#issuecomment-1253405037
Thank you @guiyanakuang !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] deshanxiao commented on pull request #1258: ORC-1278: Update cmake docs version to 3.12
Posted by GitBox <gi...@apache.org>.
deshanxiao commented on PR #1258:
URL: https://github.com/apache/orc/pull/1258#issuecomment-1254525821
> To help this PR, we need to drop `Ubuntu 18` support. I'm not sure `add_compile_definitions` is worth to drop it, but we can discuss here.
>
> ```
> $ docker run -it --rm apache/orc-dev:ubuntu18 cmake --version | head -n1
> cmake version 3.10.2
> ```
>
> WDYT, @williamhyun , @wgtmac , @guiyanakuang , @stiga-huang ?
In CMake docs:
> Note This command has been superseded by alternatives:
Use [add_compile_definitions()](https://cmake.org/cmake/help/latest/command/add_compile_definitions.html#command:add_compile_definitions) to add preprocessor definitions.
Use [include_directories()](https://cmake.org/cmake/help/latest/command/include_directories.html#command:include_directories) to add include directories.
Use [add_compile_options()](https://cmake.org/cmake/help/latest/command/add_compile_options.html#command:add_compile_options) to add other options.
We could upgrade cmake, although the lower version of add_definitions can do the same thing, but it is deprecated by official. See https://cmake.org/cmake/help/latest/command/add_definitions.html?highlight=add_definitions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] deshanxiao commented on pull request #1258: ORC-1278: Update cmake docs version to 3.12
Posted by GitBox <gi...@apache.org>.
deshanxiao commented on PR #1258:
URL: https://github.com/apache/orc/pull/1258#issuecomment-1254550071
> > To help this PR, we need to drop `Ubuntu 18` support. I'm not sure `add_compile_definitions` is worth to drop it, but we can discuss here.
> > ```
> > $ docker run -it --rm apache/orc-dev:ubuntu18 cmake --version | head -n1
> > cmake version 3.10.2
> > ```
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > WDYT, @williamhyun , @wgtmac , @guiyanakuang , @stiga-huang ?
>
> Ubuntu 18.04 is still far from its EOL date. Should we update the docker file to download & install CMake 3.12?
Thank you~ I will test all docker file and try to update it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] wgtmac commented on pull request #1258: ORC-1278: Update cmake docs version to 3.12
Posted by GitBox <gi...@apache.org>.
wgtmac commented on PR #1258:
URL: https://github.com/apache/orc/pull/1258#issuecomment-1254434300
> To help this PR, we need to drop `Ubuntu 18` support. I'm not sure `add_compile_definitions` is worth to drop it, but we can discuss here.
>
> ```
> $ docker run -it --rm apache/orc-dev:ubuntu18 cmake --version | head -n1
> cmake version 3.10.2
> ```
>
> WDYT, @williamhyun , @wgtmac , @guiyanakuang , @stiga-huang ?
Ubuntu 18.04 is still far from its EOL date. Should we update the docker file to download & install CMake 3.12?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] guiyanakuang commented on pull request #1258: ORC-1278: Update cmake docs version to 3.12
Posted by GitBox <gi...@apache.org>.
guiyanakuang commented on PR #1258:
URL: https://github.com/apache/orc/pull/1258#issuecomment-1253373472
Welcome to the Apache ORC community. What is your JIRA ID, @deshanxiao ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] deshanxiao commented on pull request #1258: ORC-1278: Update cmake docs version to 3.12
Posted by GitBox <gi...@apache.org>.
deshanxiao commented on PR #1258:
URL: https://github.com/apache/orc/pull/1258#issuecomment-1253980974
> Actually, we need to update the following together, @deshanxiao and @guiyanakuang . Could you make a followup PR?
>
> https://github.com/apache/orc/blob/541b54398d80b0fcdcc9f4c523b52c5eebd96a16/CMakeLists.txt#L13
@dongjoon-hyun Thank you~ Will make a followup PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org