You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openoffice.apache.org by Zhang Lu <zh...@gmail.com> on 2012/07/25 07:11:27 UTC
[Call-for-Review][Calc]Data validity works incorrectly with criteria "Allow text length" for numbers
Hi~
One fix for review.
https://issues.apache.org/ooo/show_bug.cgi?id=93128
Step:
1 Select the cells for which you want to define a new validity rule
2 Choose Data - Validity
3 On the Criteria tab page, enter the conditions for new values entered into
cells
4 In the Allow field, select "Text length"
5 In the Data field, select such as "less than"
6 In the Value field, enter into "10"
Result:
If you enter "11111" into the cells for which you want to define a new
validity rule, there is a error message "Invalidate value".
Expectation:
we can enter anything into the cells
Root cause: There is no flow to handle a real number when selecting string
length operation
Solution: if operation is string length type, to get the number's length,
and consider it as a string.
Re: [Call-for-Review][Calc]Data validity works incorrectly with criteria "Allow text length" for numbers
Posted by Lei Wang <le...@gmail.com>.
Herbert, thank you for applying the patch. I planed to do it. But after
merging this patch and updating to latest trunk code, I can not build trunk
successfully for several days.
On Wed, Aug 1, 2012 at 9:53 PM, Herbert Duerr <hd...@apache.org> wrote:
> On 25.07.2012 07:11, Zhang Lu wrote:
>
>> One fix for review.
>>
>> https://issues.apache.org/ooo/**show_bug.cgi?id=93128<https://issues.apache.org/ooo/show_bug.cgi?id=93128>
>> [...]
>>
>> Root cause: There is no flow to handle a real number when selecting string
>> length operation
>>
>> Solution: if operation is string length type, to get the number's length,
>> and consider it as a string.
>>
>
> Great! I reviewed, tested and applied your patch.
>
> Herbert
>
Re: [Call-for-Review][Calc]Data validity works incorrectly with criteria "Allow text length" for numbers
Posted by Herbert Duerr <hd...@apache.org>.
On 25.07.2012 07:11, Zhang Lu wrote:
> One fix for review.
>
> https://issues.apache.org/ooo/show_bug.cgi?id=93128
>[...]
> Root cause: There is no flow to handle a real number when selecting string
> length operation
>
> Solution: if operation is string length type, to get the number's length,
> and consider it as a string.
Great! I reviewed, tested and applied your patch.
Herbert
Re: [Call-for-Review][Calc]Data validity works incorrectly with criteria "Allow text length" for numbers
Posted by Lei Wang <le...@gmail.com>.
I am taking care of this
On Wed, Jul 25, 2012 at 1:11 PM, Zhang Lu <zh...@gmail.com> wrote:
> Hi~
>
> One fix for review.
>
> https://issues.apache.org/ooo/show_bug.cgi?id=93128
>
> Step:
>
> 1 Select the cells for which you want to define a new validity rule
> 2 Choose Data - Validity
> 3 On the Criteria tab page, enter the conditions for new values entered
> into
> cells
> 4 In the Allow field, select "Text length"
> 5 In the Data field, select such as "less than"
> 6 In the Value field, enter into "10"
>
> Result:
> If you enter "11111" into the cells for which you want to define a new
> validity rule, there is a error message "Invalidate value".
>
> Expectation:
> we can enter anything into the cells
>
>
> Root cause: There is no flow to handle a real number when selecting string
> length operation
>
> Solution: if operation is string length type, to get the number's length,
> and consider it as a string.
>