You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/11/03 12:28:52 UTC

[GitHub] [activemq-artemis] tlbueno opened a new pull request #3836: NO_JIRA fix extra-tests formatting and examples compilation

tlbueno opened a new pull request #3836:
URL: https://github.com/apache/activemq-artemis/pull/3836


   - Checkstyle verification fails on JMSXDeliveryCountTest
   because of empty line with trailing spaces
   ```
   [INFO] --- maven-checkstyle-plugin:3.1.1:check (default) @ extra-tests ---
   [INFO] Starting audit...
   [ERROR] /home/buildadm/workspace/upstream-test-suite/validate-install-tests/validate-install-tests-upstream/artemis-src/tests/extra-tests/src/test/java/org/apache/activemq/artemis/tests/extras/jms/xa/JMSXDeliveryCountTest.java:681: Line has trailing spaces. [RegexpSingleline]
   Audit done.
   [INFO] There is 1 error reported by Checkstyle 8.43 with /home/buildadm/workspace/upstream-test-suite/validate-install-tests/validate-install-tests-upstream/artemis-src/tests/extra-tests/../../etc/checkstyle.xml ruleset.
   [ERROR] src/test/java/org/apache/activemq/artemis/tests/extras/jms/xa/JMSXDeliveryCountTest.java:[681] (regexp) RegexpSingleline: Line has trailing spaces.
   ```
   
   - examples classes DummyXid failed to compile because of
   uncommented separation comment:
   ```
   [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project xa-heuristic: Compilation failure: Compilation failure: 
   [ERROR] /home/tbueno/repos/github.com/tlbueno/activemq-artemis/examples/features/standard/xa-heuristic/src/main/java/org/apache/activemq/artemis/jms/example/DummyXid.java:[101,1] illegal start of type
   [ERROR] /home/tbueno/repos/github.com/tlbueno/activemq-artemis/examples/features/standard/xa-heuristic/src/main/java/org/apache/activemq/artemis/jms/example/DummyXid.java:[101,3] ';' expected
   [ERROR] /home/tbueno/repos/github.com/tlbueno/activemq-artemis/examples/features/standard/xa-heuristic/src/main/java/org/apache/activemq/artemis/jms/example/DummyXid.java:[101,5] illegal start of type
   [ERROR] /home/tbueno/repos/github.com/tlbueno/activemq-artemis/examples/features/standard/xa-heuristic/src/main/java/org/apache/activemq/artemis/jms/example/DummyXid.java:[101,7] <identifier> expected
   [ERROR] /home/tbueno/repos/github.com/tlbueno/activemq-artemis/examples/features/standard/xa-heuristic/src/main/java/org/apache/activemq/artemis/jms/example/DummyXid.java:[101,9] ';' expected
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] brusdev merged pull request #3836: ARTEMIS-3538 fix extra-tests formatting and examples compilation

Posted by GitBox <gi...@apache.org>.
brusdev merged pull request #3836:
URL: https://github.com/apache/activemq-artemis/pull/3836


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] brusdev commented on pull request #3836: ARTEMIS-3538 fix extra-tests formatting and examples compilation

Posted by GitBox <gi...@apache.org>.
brusdev commented on pull request #3836:
URL: https://github.com/apache/activemq-artemis/pull/3836#issuecomment-958998890


   @gemmellr I'll merge this PR soon after checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] gemmellr commented on pull request #3836: ARTEMIS-3538 fix extra-tests formatting and examples compilation

Posted by GitBox <gi...@apache.org>.
gemmellr commented on pull request #3836:
URL: https://github.com/apache/activemq-artemis/pull/3836#issuecomment-958997834


   Was about to push a fix but hadnt seen this opened, I'll leave it to @brusdev to apply this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] brusdev commented on pull request #3836: NO_JIRA fix extra-tests formatting and examples compilation

Posted by GitBox <gi...@apache.org>.
brusdev commented on pull request #3836:
URL: https://github.com/apache/activemq-artemis/pull/3836#issuecomment-958996146


   @tlbueno please replace NO-JIRA with ARTEMIS-3538


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] brusdev commented on pull request #3836: NO_JIRA fix extra-tests formatting and examples compilation

Posted by GitBox <gi...@apache.org>.
brusdev commented on pull request #3836:
URL: https://github.com/apache/activemq-artemis/pull/3836#issuecomment-958996146






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] brusdev merged pull request #3836: ARTEMIS-3538 fix extra-tests formatting and examples compilation

Posted by GitBox <gi...@apache.org>.
brusdev merged pull request #3836:
URL: https://github.com/apache/activemq-artemis/pull/3836






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] gemmellr commented on pull request #3836: ARTEMIS-3538 fix extra-tests formatting and examples compilation

Posted by GitBox <gi...@apache.org>.
gemmellr commented on pull request #3836:
URL: https://github.com/apache/activemq-artemis/pull/3836#issuecomment-958997834






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] brusdev merged pull request #3836: ARTEMIS-3538 fix extra-tests formatting and examples compilation

Posted by GitBox <gi...@apache.org>.
brusdev merged pull request #3836:
URL: https://github.com/apache/activemq-artemis/pull/3836


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] brusdev commented on pull request #3836: NO_JIRA fix extra-tests formatting and examples compilation

Posted by GitBox <gi...@apache.org>.
brusdev commented on pull request #3836:
URL: https://github.com/apache/activemq-artemis/pull/3836#issuecomment-958996146






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] gemmellr commented on pull request #3836: ARTEMIS-3538 fix extra-tests formatting and examples compilation

Posted by GitBox <gi...@apache.org>.
gemmellr commented on pull request #3836:
URL: https://github.com/apache/activemq-artemis/pull/3836#issuecomment-958997834


   Was about to push a fix but hadnt seen this opened, I'll leave it to @brusdev to apply this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org