You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/06/01 08:25:25 UTC
[GitHub] [commons-lang] XenoAmess opened a new pull request #550: change_removeLastFieldSeparator_to_use_endsWith
XenoAmess opened a new pull request #550:
URL: https://github.com/apache/commons-lang/pull/550
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] coveralls commented on pull request #550: change_removeLastFieldSeparator_to_use_endsWith
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #550:
URL: https://github.com/apache/commons-lang/pull/550#issuecomment-636710503
[](https://coveralls.io/builds/31154636)
Coverage decreased (-0.003%) to 95.038% when pulling **947d371f8d757e07b4b2d59893b8d739cfc09d3a on XenoAmess:change_removeLastFieldSeparator_to_use_endsWith** into **3d4ed4a8ac63db1e51601ffc31fed44dccbb276c on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] XenoAmess commented on pull request #550: change_removeLastFieldSeparator_to_use_endsWith
Posted by GitBox <gi...@apache.org>.
XenoAmess commented on pull request #550:
URL: https://github.com/apache/commons-lang/pull/550#issuecomment-636713628
or if you think StringUtils.endsWith() is low performance here, you can at least use StringBuffer.lastIndexOf.
that is both high performance and readability.
Or, you can wait for me to refine StringUtils.endWith.
I'm refining CharSequenceUtils.lastIndexOf recently, and I have a plan to refine them all.
see https://github.com/apache/commons-lang/pull/535
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] XenoAmess commented on pull request #550: [LANG-1565] change removeLastFieldSeparator to use endsWith
Posted by GitBox <gi...@apache.org>.
XenoAmess commented on pull request #550:
URL: https://github.com/apache/commons-lang/pull/550#issuecomment-643688244
> Please rebase.
@garydgregory done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] coveralls edited a comment on pull request #550: [LANG-1565] change removeLastFieldSeparator to use endsWith
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #550:
URL: https://github.com/apache/commons-lang/pull/550#issuecomment-636710503
[](https://coveralls.io/builds/31440015)
Coverage decreased (-0.003%) to 95.026% when pulling **d3e1cda30d8ae19a7cb48ecb1bb43ffe6b523eee on XenoAmess:change_removeLastFieldSeparator_to_use_endsWith** into **9fcd9c86edc05a0bd25f8eb73cf840400e5e6b95 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory merged pull request #550: [LANG-1565] change removeLastFieldSeparator to use endsWith
Posted by GitBox <gi...@apache.org>.
garydgregory merged pull request #550:
URL: https://github.com/apache/commons-lang/pull/550
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] coveralls edited a comment on pull request #550: [LANG-1565] change removeLastFieldSeparator to use endsWith
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #550:
URL: https://github.com/apache/commons-lang/pull/550#issuecomment-636710503
[](https://coveralls.io/builds/31296651)
Coverage decreased (-0.003%) to 95.038% when pulling **16f6c24e29411aa6bab8c389edefabd4c0b2a6de on XenoAmess:change_removeLastFieldSeparator_to_use_endsWith** into **3d4ed4a8ac63db1e51601ffc31fed44dccbb276c on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on pull request #550: [LANG-1565] change removeLastFieldSeparator to use endsWith
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #550:
URL: https://github.com/apache/commons-lang/pull/550#issuecomment-643686797
Please rebase.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org