You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoram Thanga (Code Review)" <ge...@cloudera.org> on 2018/07/17 22:06:21 UTC
[Impala-ASF-CR] IMPALA-7014: Disable stacktrace symbolisation by default
Zoram Thanga has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10964
Change subject: IMPALA-7014: Disable stacktrace symbolisation by default
......................................................................
IMPALA-7014: Disable stacktrace symbolisation by default
Stacktrace symbolization has been shown to be 2500x slower
compared to just printing the un-symbolized one.
This has burned us a few times now, so let's disable it by
default.
Change-Id: If3af209890ccc242beb742145c63eb6836d4bfbb
---
M be/src/common/init.cc
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/10964/1
--
To view, visit http://gerrit.cloudera.org:8080/10964
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If3af209890ccc242beb742145c63eb6836d4bfbb
Gerrit-Change-Number: 10964
Gerrit-PatchSet: 1
Gerrit-Owner: Zoram Thanga <zo...@cloudera.com>
[Impala-ASF-CR] IMPALA-7014: Disable stacktrace symbolisation by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10964 )
Change subject: IMPALA-7014: Disable stacktrace symbolisation by default
......................................................................
IMPALA-7014: Disable stacktrace symbolisation by default
Stacktrace symbolization has been shown to be 2500x slower
compared to just printing the un-symbolized one.
This has burned us a few times now, so let's disable it by
default.
Change-Id: If3af209890ccc242beb742145c63eb6836d4bfbb
Reviewed-on: http://gerrit.cloudera.org:8080/10964
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/common/init.cc
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/10964
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If3af209890ccc242beb742145c63eb6836d4bfbb
Gerrit-Change-Number: 10964
Gerrit-PatchSet: 3
Gerrit-Owner: Zoram Thanga <zo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-7014: Disable stacktrace symbolisation by default
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10964 )
Change subject: IMPALA-7014: Disable stacktrace symbolisation by default
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10964
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If3af209890ccc242beb742145c63eb6836d4bfbb
Gerrit-Change-Number: 10964
Gerrit-PatchSet: 1
Gerrit-Owner: Zoram Thanga <zo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Jul 2018 23:29:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7014: Disable stacktrace symbolisation by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10964 )
Change subject: IMPALA-7014: Disable stacktrace symbolisation by default
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/10964
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If3af209890ccc242beb742145c63eb6836d4bfbb
Gerrit-Change-Number: 10964
Gerrit-PatchSet: 2
Gerrit-Owner: Zoram Thanga <zo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Jul 2018 02:43:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7014: Disable stacktrace symbolisation by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10964 )
Change subject: IMPALA-7014: Disable stacktrace symbolisation by default
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10964
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If3af209890ccc242beb742145c63eb6836d4bfbb
Gerrit-Change-Number: 10964
Gerrit-PatchSet: 2
Gerrit-Owner: Zoram Thanga <zo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Jul 2018 23:29:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7014: Disable stacktrace symbolisation by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10964 )
Change subject: IMPALA-7014: Disable stacktrace symbolisation by default
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2828/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/10964
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If3af209890ccc242beb742145c63eb6836d4bfbb
Gerrit-Change-Number: 10964
Gerrit-PatchSet: 2
Gerrit-Owner: Zoram Thanga <zo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Jul 2018 23:30:00 +0000
Gerrit-HasComments: No