You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mina.apache.org by "Emmanuel Lecharny (JIRA)" <ji...@apache.org> on 2017/04/25 08:00:19 UTC

[jira] [Updated] (FTPSERVER-378) [FindBugs] Method DefaultFtpStatistics::setLogin() call passes null for nonnull parameter of new DefaultFtpStatistics$UserLogins(InetAddress)

     [ https://issues.apache.org/jira/browse/FTPSERVER-378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emmanuel Lecharny updated FTPSERVER-378:
----------------------------------------
    Fix Version/s:     (was: 1.1.1)
                   1.1.2

> [FindBugs] Method DefaultFtpStatistics::setLogin() call passes null for nonnull parameter of new DefaultFtpStatistics$UserLogins(InetAddress)
> ---------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: FTPSERVER-378
>                 URL: https://issues.apache.org/jira/browse/FTPSERVER-378
>             Project: FtpServer
>          Issue Type: Bug
>          Components: Core
>            Reporter: Sergey Vladimirov
>            Priority: Minor
>              Labels: findbugs, npe
>             Fix For: 1.0.0-M1, 1.1.2
>
>
> If session.getRemoteAddress() is not instanceof InetSocketAddress, then address is null. But UserLogins do not accept nulls as argument (null can't be a key for ConcurrentHashMap)
> I think 'fake' NULL address constant shall be introduced in DefaultFtpStatistics for this case.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)