You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Sailesh Mukil (Code Review)" <ge...@cloudera.org> on 2016/07/06 18:35:33 UTC
[Impala-CR](cdh5-trunk) IMPALA-3779: Disable cache pool reader thread when HDFS isn't running
Sailesh Mukil has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3577
Change subject: IMPALA-3779: Disable cache pool reader thread when HDFS isn't running
......................................................................
IMPALA-3779: Disable cache pool reader thread when HDFS isn't running
When running Impala on S3 (without hdfs started) the logs every
minute produced an error which detailed that the HDFS cache pool
couldn't be read from. This change disables the cache pool reader
thread if HDFS is not the default filesystem.
Change-Id: I2ff3769fff9099aed88a6a587aa721b3487216bd
---
M fe/src/main/java/com/cloudera/impala/catalog/CatalogServiceCatalog.java
M fe/src/main/java/com/cloudera/impala/common/FileSystemUtil.java
2 files changed, 14 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/77/3577/1
--
To view, visit http://gerrit.cloudera.org:8080/3577
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2ff3769fff9099aed88a6a587aa721b3487216bd
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
[Impala-CR](cdh5-trunk) IMPALA-3779: Disable cache pool reader thread when HDFS isn't running
Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Hello Henry Robinson,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3577
to look at the new patch set (#3).
Change subject: IMPALA-3779: Disable cache pool reader thread when HDFS isn't running
......................................................................
IMPALA-3779: Disable cache pool reader thread when HDFS isn't running
When running Impala on S3 (without hdfs started) the logs every
minute produced an error which detailed that the HDFS cache pool
couldn't be read from. This change disables the cache pool reader
thread if HDFS is not the default filesystem.
Change-Id: I2ff3769fff9099aed88a6a587aa721b3487216bd
---
M fe/src/main/java/com/cloudera/impala/catalog/CatalogServiceCatalog.java
M fe/src/main/java/com/cloudera/impala/common/FileSystemUtil.java
2 files changed, 17 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/77/3577/3
--
To view, visit http://gerrit.cloudera.org:8080/3577
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2ff3769fff9099aed88a6a587aa721b3487216bd
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
[Impala-CR](cdh5-trunk) IMPALA-3779: Disable cache pool reader thread when HDFS isn't running
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-3779: Disable cache pool reader thread when HDFS isn't running
......................................................................
IMPALA-3779: Disable cache pool reader thread when HDFS isn't running
When running Impala on S3 (without hdfs started) the logs every
minute produced an error which detailed that the HDFS cache pool
couldn't be read from. This change disables the cache pool reader
thread if HDFS is not the default filesystem.
Change-Id: I2ff3769fff9099aed88a6a587aa721b3487216bd
Reviewed-on: http://gerrit.cloudera.org:8080/3577
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Internal Jenkins
---
M fe/src/main/java/com/cloudera/impala/catalog/CatalogServiceCatalog.java
M fe/src/main/java/com/cloudera/impala/common/FileSystemUtil.java
2 files changed, 17 insertions(+), 2 deletions(-)
Approvals:
Internal Jenkins: Verified
Alex Behm: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/3577
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2ff3769fff9099aed88a6a587aa721b3487216bd
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
[Impala-CR](cdh5-trunk) IMPALA-3779: Disable cache pool reader thread when HDFS isn't running
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-3779: Disable cache pool reader thread when HDFS isn't running
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Need Alex or Marcel to look at FSU.java.
http://gerrit.cloudera.org:8080/#/c/3577/1/fe/src/main/java/com/cloudera/impala/catalog/CatalogServiceCatalog.java
File fe/src/main/java/com/cloudera/impala/catalog/CatalogServiceCatalog.java:
PS1, Line 166: cachePoolReader_.scheduleAtFixedRate(new CachePoolReader(), 0, 1, TimeUnit.MINUTES);
long line
--
To view, visit http://gerrit.cloudera.org:8080/3577
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ff3769fff9099aed88a6a587aa721b3487216bd
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-CR](cdh5-trunk) IMPALA-3779: Disable cache pool reader thread when HDFS isn't running
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-3779: Disable cache pool reader thread when HDFS isn't running
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/3577
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ff3769fff9099aed88a6a587aa721b3487216bd
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) IMPALA-3779: Disable cache pool reader thread when HDFS isn't running
Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Hello Henry Robinson,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3577
to look at the new patch set (#2).
Change subject: IMPALA-3779: Disable cache pool reader thread when HDFS isn't running
......................................................................
IMPALA-3779: Disable cache pool reader thread when HDFS isn't running
When running Impala on S3 (without hdfs started) the logs every
minute produced an error which detailed that the HDFS cache pool
couldn't be read from. This change disables the cache pool reader
thread if HDFS is not the default filesystem.
Change-Id: I2ff3769fff9099aed88a6a587aa721b3487216bd
---
M fe/src/main/java/com/cloudera/impala/catalog/CatalogServiceCatalog.java
M fe/src/main/java/com/cloudera/impala/common/FileSystemUtil.java
2 files changed, 15 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/77/3577/2
--
To view, visit http://gerrit.cloudera.org:8080/3577
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2ff3769fff9099aed88a6a587aa721b3487216bd
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
[Impala-CR](cdh5-trunk) IMPALA-3779: Disable cache pool reader thread when HDFS isn't running
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: IMPALA-3779: Disable cache pool reader thread when HDFS isn't running
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3577
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ff3769fff9099aed88a6a587aa721b3487216bd
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) IMPALA-3779: Disable cache pool reader thread when HDFS isn't running
Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Sailesh Mukil has posted comments on this change.
Change subject: IMPALA-3779: Disable cache pool reader thread when HDFS isn't running
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/3577/1/fe/src/main/java/com/cloudera/impala/catalog/CatalogServiceCatalog.java
File fe/src/main/java/com/cloudera/impala/catalog/CatalogServiceCatalog.java:
PS1, Line 166: / local, etc.)
> long line
Done
http://gerrit.cloudera.org:8080/#/c/3577/2/fe/src/main/java/com/cloudera/impala/catalog/CatalogServiceCatalog.java
File fe/src/main/java/com/cloudera/impala/catalog/CatalogServiceCatalog.java:
Line 165: // We want only 'true' HDFS filesystems to poll the HDFS cache (i.e not S3,
> Add a comment that we only expect 'true' HDFS file systems to poll the HDFS
Done
--
To view, visit http://gerrit.cloudera.org:8080/3577
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ff3769fff9099aed88a6a587aa721b3487216bd
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-CR](cdh5-trunk) IMPALA-3779: Disable cache pool reader thread when HDFS isn't running
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: IMPALA-3779: Disable cache pool reader thread when HDFS isn't running
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3577/2/fe/src/main/java/com/cloudera/impala/catalog/CatalogServiceCatalog.java
File fe/src/main/java/com/cloudera/impala/catalog/CatalogServiceCatalog.java:
Line 165: if (FileSystemUtil.getDefaultFileSystem() instanceof DistributedFileSystem) {
Add a comment that we only expect 'true' HDFS file systems to poll the HDFS cache (and not S3, Isilon, etc.)
--
To view, visit http://gerrit.cloudera.org:8080/3577
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ff3769fff9099aed88a6a587aa721b3487216bd
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-HasComments: Yes