You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cloudstack.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/05/22 12:15:17 UTC

[jira] [Commented] (CLOUDSTACK-8502) Implement Annotions for XenServer and Libvirt resources

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-8502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14555937#comment-14555937 ] 

ASF GitHub Bot commented on CLOUDSTACK-8502:
--------------------------------------------

Github user wilderrodrigues commented on the pull request:

    https://github.com/apache/cloudstack/pull/280#issuecomment-104608654
  
    @bhaisaab @mlsorensen
    
    If you are okay with the result, I will merge the PR this afternoon.
    
    Environments:
    
    Centos7 + KVM + Qemu
    MySQL/MariaDB 5.5.41
    Management Server running CentOS 7
    Component/Smoke tests: https://github.com/apache/cloudstack (test/integration/component and smoke)
    Storage type: NFS shared
    Isolation method: VLAN
    Agent: 4.6.0
    
    XenServer 6.2
    MySQL/MariaDB 5.5.41
    Management Server running CentOS 7
    Component/Smoke tests: https://github.com/apache/cloudstack (test/integration/component and smoke)
    Storage type: NFS shared
    Isolation method: VLAN
    
    
    ================== KVM tests ==================
    
    Test advanced zone virtual router ... === TestName: test_advZoneVirtualRouter | Status : SUCCESS ===
    ok
    Test Deploy Virtual Machine ... === TestName: test_deploy_vm | Status : SUCCESS ===
    ok
    Test Multiple Deploy Virtual Machine ... === TestName: test_deploy_vm_multiple | Status : SUCCESS ===
    ok
    Test Stop Virtual Machine ... === TestName: test_01_stop_vm | Status : SUCCESS ===
    ok
    Test Start Virtual Machine ... === TestName: test_02_start_vm | Status : SUCCESS ===
    ok
    Test Reboot Virtual Machine ... === TestName: test_03_reboot_vm | Status : SUCCESS ===
    ok
    Test destroy Virtual Machine ... === TestName: test_06_destroy_vm | Status : SUCCESS ===
    ok
    Test recover Virtual Machine ... === TestName: test_07_restore_vm | Status : SUCCESS ===
    ok
    Test migrate VM ... SKIP: At least two hosts should be present in the zone for migration
    Test destroy(expunge) Virtual Machine ... === TestName: test_09_expunge_vm | Status : SUCCESS ===
    ok
    
    ----------------------------------------------------------------------
    Ran 10 tests in 2698.252s
    
    OK (SKIP=1)
    /tmp//MarvinLogs/test_vm_life_cycle_DZNVX5/results.txt (END)
    
    
    Test Create Account and user for that account ... === TestName: test_01_create_account | Status : SUCCESS ===
    ok
    Test Sub domain allowed to launch VM  when a Domain ... === TestName: test_01_add_vm_to_subdomain | Status : SUCCESS ===
    ok
    Test delete domain without force option ... === TestName: test_DeleteDomain | Status : SUCCESS ===
    ok
    Test delete domain with force option ... === TestName: test_forceDeleteDomain | Status : SUCCESS ===
    ok
    Test to verify Non Root admin previleges ... === TestName: test_01_non_root_admin_Privileges | Status : SUCCESS ===
    ok
    Test Remove one user from the account ... === TestName: test_01_user_remove_VM_running | Status : SUCCESS ===
    ok
    Test to verify service offerings at same level in hierarchy ... === TestName: test_01_service_offering_hierarchy | Status : SUCCESS ===
    ok
    Test to verify service offerings at same level in hierarchy ... === TestName: test_01_service_offering_siblings | Status : SUCCESS ===
    ok
    Test to verify template at same level in hierarchy ... === TestName: test_01_template_hierarchy | Status : SUCCESS ===
    ok
    Test update admin details ... === TestName: test_updateAdminDetails | Status : SUCCESS ===
    ok
    Test update domain admin details ... === TestName: test_updateDomainAdminDetails | Status : SUCCESS ===
    ok
    Test user update API ... === TestName: test_updateUserDetails | Status : SUCCESS ===
    ok
    Test login API with domain ... === TestName: test_LoginApiDomain | Status : SUCCESS ===
    ok
    Test if Login API does not return UUID's ... === TestName: test_LoginApiUuidResponse | Status : SUCCESS ===
    ok
    
    ----------------------------------------------------------------------
    Ran 14 tests in 6499.442s
    
    OK
    /tmp//MarvinLogs/test_accounts_8RTDXH/results.txt (END)
    
    
    ================== XenServer 6.2 tests ==================
    
    Test advanced zone virtual router ... === TestName: test_advZoneVirtualRouter | Status : SUCCESS ===
    ok
    Test Deploy Virtual Machine ... === TestName: test_deploy_vm | Status : SUCCESS ===
    ok
    Test Multiple Deploy Virtual Machine ... === TestName: test_deploy_vm_multiple | Status : SUCCESS ===
    ok
    Test Stop Virtual Machine ... === TestName: test_01_stop_vm | Status : SUCCESS ===
    ok
    Test Start Virtual Machine ... === TestName: test_02_start_vm | Status : SUCCESS ===
    ok
    Test Reboot Virtual Machine ... === TestName: test_03_reboot_vm | Status : SUCCESS ===
    ok
    Test destroy Virtual Machine ... === TestName: test_06_destroy_vm | Status : SUCCESS ===
    ok
    Test recover Virtual Machine ... === TestName: test_07_restore_vm | Status : SUCCESS ===
    ok
    Test migrate VM ... SKIP: At least two hosts should be present in the zone for migration
    Test destroy(expunge) Virtual Machine ... === TestName: test_09_expunge_vm | Status : SUCCESS ===
    ok
    
    ----------------------------------------------------------------------
    Ran 10 tests in 872.307s
    
    OK (SKIP=1)
    /tmp//MarvinLogs/test_vm_life_cycle_D6HQHB/results.txt (END)
    
    
    Test Create Account and user for that account ... === TestName: test_01_create_account | Status : SUCCESS ===
    ok
    Test Sub domain allowed to launch VM  when a Domain ... === TestName: test_01_add_vm_to_subdomain | Status : SUCCESS ===
    ok
    Test delete domain without force option ... === TestName: test_DeleteDomain | Status : SUCCESS ===
    ok
    Test delete domain with force option ... === TestName: test_forceDeleteDomain | Status : SUCCESS ===
    ok
    Test to verify Non Root admin previleges ... === TestName: test_01_non_root_admin_Privileges | Status : SUCCESS ===
    ok
    Test Remove one user from the account ... === TestName: test_01_user_remove_VM_running | Status : SUCCESS ===
    ok
    Test to verify service offerings at same level in hierarchy ... === TestName: test_01_service_offering_hierarchy | Status : SUCCESS ===
    ok
    Test to verify service offerings at same level in hierarchy ... === TestName: test_01_service_offering_siblings | Status : SUCCESS ===
    ok
    Test to verify template at same level in hierarchy ... === TestName: test_01_template_hierarchy | Status : SUCCESS ===
    ok
    Test update admin details ... === TestName: test_updateAdminDetails | Status : SUCCESS ===
    ok
    Test update domain admin details ... === TestName: test_updateDomainAdminDetails | Status : SUCCESS ===
    ok
    Test user update API ... === TestName: test_updateUserDetails | Status : SUCCESS ===
    ok
    Test login API with domain ... === TestName: test_LoginApiDomain | Status : SUCCESS ===
    ok
    Test if Login API does not return UUID's ... === TestName: test_LoginApiUuidResponse | Status : SUCCESS ===
    ok
    
    ----------------------------------------------------------------------
    Ran 14 tests in 1320.486s
    
    OK
    /tmp//MarvinLogs/test_accounts_1TSTJ1/results.txt (END)


> Implement Annotions for XenServer and Libvirt resources
> -------------------------------------------------------
>
>                 Key: CLOUDSTACK-8502
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8502
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Wilder Rodrigues
>            Assignee: Wilder Rodrigues
>            Priority: Minor
>
> The way the refactoring of the XenServer and Libvirt resources was done helped a lot to increase maintainability, compared to what it was before:
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Refactoring+XenServer+Hypervisor+Plugin
> However, in order to make sure we don need to change the LibvirtRequestWrapper or CitrixRequestWrapper ever, we are now using annotation on the CommandWrapper implementations.
> The documentation will be updated in order to depict the Annotations design.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)