You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by zwoop <gi...@git.apache.org> on 2016/06/30 21:39:58 UTC
[GitHub] trafficserver pull request #777: TS-4623 Adds a pre-commit script for git
GitHub user zwoop opened a pull request:
https://github.com/apache/trafficserver/pull/777
TS-4623 Adds a pre-commit script for git
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zwoop/trafficserver TS-4623
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/777.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #777
----
commit fc7e10f61674ecfa41c97bd208f0a17e1c190c99
Author: Leif Hedstrom <zw...@apache.org>
Date: 2016-06-30T21:39:10Z
TS-4623 Adds a pre-commit script for git
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #777: TS-4623 Adds a pre-commit script for git
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/777
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #777: TS-4623 Adds a pre-commit script for git
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/777
\U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #777: TS-4623 Adds a pre-commit script for git
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/777
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/288/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #777: TS-4623 Adds a pre-commit script for git
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/777
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/392/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #777: TS-4623 Adds a pre-commit script for git
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/777#discussion_r69379428
--- Diff: tools/pre-commit ---
@@ -0,0 +1,66 @@
+#! /usr/bin/env bash
+#
+# Simple pre-commit hook script, enforcing clang-format on our tree
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+ROOT=$(git rev-parse --show-toplevel)/.git/fmt
+case $(uname -s) in
+Darwin)
+ FORMAT=${FORMAT:-${ROOT}/clang-format/clang-format.osx}
+ ;;
+Linux)
+ FORMAT=${FORMAT:-${ROOT}/clang-format/clang-format.linux}
+ ;;
+*)
+ echo "Leif needs to build a clang-format for $(uname -s)"
--- End diff --
Hmmm, I copied / borrowed that from your clang-format.sh script ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #777: TS-4623 Adds a pre-commit script for git
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/777#discussion_r69330732
--- Diff: tools/pre-commit ---
@@ -0,0 +1,66 @@
+#! /usr/bin/env bash
+#
+# Simple pre-commit hook script, enforcing clang-format on our tree
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+ROOT=$(git rev-parse --show-toplevel)/.git/fmt
+case $(uname -s) in
+Darwin)
+ FORMAT=${FORMAT:-${ROOT}/clang-format/clang-format.osx}
+ ;;
+Linux)
+ FORMAT=${FORMAT:-${ROOT}/clang-format/clang-format.linux}
+ ;;
+*)
+ echo "Leif needs to build a clang-format for $(uname -s)"
--- End diff --
Just run $(git rev-parse --show-toplevel)/tools/clang-format.sh here ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #777: TS-4623 Adds a pre-commit script for git
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/777
Need input from the git expert, too bad @bgaff doesn't have a computer still :-/. So will have to settle for @jpeach and @PSUdaemon .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---