Re: svn commit: rev 3091 - trunk/subversion/libsvn_wc

[Philip Martin <ph...@codematters.co.uk>]

kfogel@tigris.org writes:

> Modified: trunk/subversion/libsvn_wc/copy.c
> ==============================================================================
> --- trunk/subversion/libsvn_wc/copy.c	(original)
> +++ trunk/subversion/libsvn_wc/copy.c	Wed Aug 28 14:16:19 2002
> @@ -56,7 +56,7 @@
>  
>    /* Remove this_dir's wcprops */
>    SVN_ERR (svn_wc__wcprop_path (&wcprop_path, path, 0, subpool));
> -  (void) apr_file_remove (wcprop_path, subpool);
> +  (void) svn_io_remove_file (wcprop_path, subpool);


An ignored error should go through svn_error_clear_all.

-- 
Philip Martin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: rev 3091 - trunk/subversion/libsvn_wc

[Karl Fogel <kf...@newton.ch.collab.net>]

Philip Martin <ph...@codematters.co.uk> writes:
> >    SVN_ERR (svn_wc__wcprop_path (&wcprop_path, path, 0, subpool));
> > -  (void) apr_file_remove (wcprop_path, subpool);
> > +  (void) svn_io_remove_file (wcprop_path, subpool);
> 
> An ignored error should go through svn_error_clear_all.

Thanks.

There are two such calls in the file now, so both should be fixed.
But also, reading the comment near the second call, I'm wondering if
maybe we should check that err->apr_err is something expected before
ignoring (clearing) the error, too...?

(I won't be taking care of this today, just fyi, so feel free if you
want.)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org