You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/09/22 23:53:08 UTC
[GitHub] [arrow] kou edited a comment on pull request #8243: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
kou edited a comment on pull request #8243:
URL: https://github.com/apache/arrow/pull/8243#issuecomment-697040532
For the aws-sdk headers, the following patch will fix them:
```diff
diff --git a/cpp/cmake_modules/ThirdpartyToolchain.cmake b/cpp/cmake_modules/ThirdpartyToolchain.cmake
index 0180ef912..033e18491 100644
--- a/cpp/cmake_modules/ThirdpartyToolchain.cmake
+++ b/cpp/cmake_modules/ThirdpartyToolchain.cmake
@@ -2629,10 +2629,19 @@ macro(build_awssdk)
set(AWSSDK_BUILD_TYPE Release)
endif()
+ set(AWSSDK_LIST_SEPARATOR "|")
+ string(JOIN
+ ${AWSSDK_LIST_SEPARATOR}
+ AWSSDK_BUILD_ONLY
+ s3
+ core
+ config
+ identity-management
+ sts)
set(AWSSDK_CMAKE_ARGS
-DCMAKE_BUILD_TYPE=Release
-DCMAKE_INSTALL_LIBDIR=lib
- -DBUILD_ONLY=s3;core;config;identity-management;sts
+ -DBUILD_ONLY=${AWSSDK_BUILD_ONLY}
-DENABLE_UNITY_BUILD=on
-DENABLE_TESTING=off
"-DCMAKE_C_FLAGS=${EP_C_FLAGS}"
@@ -2661,7 +2670,8 @@ macro(build_awssdk)
${EP_LOG_OPTIONS}
URL ${AWSSDK_SOURCE_URL}
CMAKE_ARGS ${AWSSDK_CMAKE_ARGS}
- BUILD_BYPRODUCTS ${AWSSDK_SHARED_LIBS})
+ BUILD_BYPRODUCTS ${AWSSDK_SHARED_LIBS}
+ LIST_SEPARATOR ${AWSSDK_LIST_SEPARATOR})
file(MAKE_DIRECTORY ${AWSSDK_INCLUDE_DIR})
```
We need to escape `;` in `BUILD_ONLY`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org