You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2017/04/20 15:41:12 UTC

Review Request 58577: Autofix db leads to dangling entries in ClusterConfigMapping table

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58577/
-----------------------------------------------------------

Review request for Ambari, Jonathan Hurley and Nate Cole.


Bugs: AMBARI-20805
    https://issues.apache.org/jira/browse/AMBARI-20805


Repository: ambari


Description
-------

Existing implementation removes all entities of the same type


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java 4cdeecb153 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterDAO.java b727c720bb 


Diff: https://reviews.apache.org/r/58577/diff/1/


Testing
-------

mvn clean test


Thanks,

Dmitro Lisnichenko


Re: Review Request 58577: Autofix db leads to dangling entries in ClusterConfigMapping table

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.

> On April 20, 2017, 8:03 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
> > Lines 530-532 (original), 530-532 (patched)
> > <https://reviews.apache.org/r/58577/diff/1/?file=1695541#file1695541line530>
> >
> >     Maybe these should be Log.info ?

done


> On April 20, 2017, 8:03 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterDAO.java
> > Lines 380 (patched)
> > <https://reviews.apache.org/r/58577/diff/1/?file=1695542#file1695542line380>
> >
> >     I think you should use version_tag instead of timestamp ...

thanks, fixed


- Dmitro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58577/#review172514
-----------------------------------------------------------


On April 21, 2017, 11:18 a.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58577/
> -----------------------------------------------------------
> 
> (Updated April 21, 2017, 11:18 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-20805
>     https://issues.apache.org/jira/browse/AMBARI-20805
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Existing implementation removes all entities of the same type
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java 4cdeecb153 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterDAO.java b727c720bb 
> 
> 
> Diff: https://reviews.apache.org/r/58577/diff/2/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>


Re: Review Request 58577: Autofix db leads to dangling entries in ClusterConfigMapping table

Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58577/#review172514
-----------------------------------------------------------


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
Lines 530-532 (original), 530-532 (patched)
<https://reviews.apache.org/r/58577/#comment245618>

    Maybe these should be Log.info ?



ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterDAO.java
Lines 380 (patched)
<https://reviews.apache.org/r/58577/#comment245620>

    I think you should use version_tag instead of timestamp ...


- Jonathan Hurley


On April 20, 2017, 11:41 a.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58577/
> -----------------------------------------------------------
> 
> (Updated April 20, 2017, 11:41 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-20805
>     https://issues.apache.org/jira/browse/AMBARI-20805
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Existing implementation removes all entities of the same type
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java 4cdeecb153 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterDAO.java b727c720bb 
> 
> 
> Diff: https://reviews.apache.org/r/58577/diff/1/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>


Re: Review Request 58577: Autofix db leads to dangling entries in ClusterConfigMapping table

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58577/#review172655
-----------------------------------------------------------


Ship it!




Ship It!

- Nate Cole


On April 21, 2017, 4:18 a.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58577/
> -----------------------------------------------------------
> 
> (Updated April 21, 2017, 4:18 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-20805
>     https://issues.apache.org/jira/browse/AMBARI-20805
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Existing implementation removes all entities of the same type
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java 4cdeecb153 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterDAO.java b727c720bb 
> 
> 
> Diff: https://reviews.apache.org/r/58577/diff/2/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>


Re: Review Request 58577: Autofix db leads to dangling entries in ClusterConfigMapping table

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58577/
-----------------------------------------------------------

(Updated April 21, 2017, 11:18 a.m.)


Review request for Ambari, Jonathan Hurley and Nate Cole.


Changes
-------

fix review comments


Bugs: AMBARI-20805
    https://issues.apache.org/jira/browse/AMBARI-20805


Repository: ambari


Description
-------

Existing implementation removes all entities of the same type


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java 4cdeecb153 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterDAO.java b727c720bb 


Diff: https://reviews.apache.org/r/58577/diff/2/

Changes: https://reviews.apache.org/r/58577/diff/1-2/


Testing
-------

mvn clean test


Thanks,

Dmitro Lisnichenko


Re: Review Request 58577: Autofix db leads to dangling entries in ClusterConfigMapping table

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58577/#review172515
-----------------------------------------------------------




ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterDAO.java
Lines 380 (patched)
<https://reviews.apache.org/r/58577/#comment245625>

    +1 for version tag


- Alejandro Fernandez


On April 20, 2017, 3:41 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58577/
> -----------------------------------------------------------
> 
> (Updated April 20, 2017, 3:41 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-20805
>     https://issues.apache.org/jira/browse/AMBARI-20805
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Existing implementation removes all entities of the same type
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java 4cdeecb153 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterDAO.java b727c720bb 
> 
> 
> Diff: https://reviews.apache.org/r/58577/diff/1/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>