You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by spmallette <gi...@git.apache.org> on 2017/05/20 01:46:26 UTC
[GitHub] tinkerpop pull request #608: TINKERPOP-1618 Removed dependence on groovy for...
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/608
TINKERPOP-1618 Removed dependence on groovy for gremlin-python
https://issues.apache.org/jira/browse/TINKERPOP-1618
Executed code generation with the gmavenplus plugin and the Groovy templating library. This approach also gets the files generated in a much earlier (and more correct) phase of the maven life cycle which may be important to other GLVs using this as a pattern. It may yet mean better build workflow options for gremlin-python.
Builds with `docker/build.sh -t -i -n`
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1618
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/608.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #608
----
commit 7e8b481f43c2ad744ccabee994ac47a87182fdc4
Author: Stephen Mallette <sp...@genoprime.com>
Date: 2017-05-19T18:37:27Z
TINKERPOP-1618 Removed dependence on groovy for gremlin-python
Executed code generation with the gmaven plugin and the Groovy templating library. This approach also gets the files generated in a much earlier (and more correct) phase of the maven life cycle which may be important to other GLVs using this as a pattern.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #608: TINKERPOP-1618 Removed dependence on groovy for gremli...
Posted by okram <gi...@git.apache.org>.
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/608
Cool! -- VOTE +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #608: TINKERPOP-1618 Removed dependence on groovy for gremli...
Posted by dkuppitz <gi...@git.apache.org>.
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/608
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop pull request #608: TINKERPOP-1618 Removed dependence on groovy for...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/608
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---