[jira] [Commented] (SOLR-2578) ReplicationHandler Backups -- clean up old backups

["Neil Hooey (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-2578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13215402#comment-13215402 ] 

Neil Hooey commented on SOLR-2578:
----------------------------------

This doesn't seem to work for me on trunk.

It only deletes snapshots if you set numberToKeep=1.

I checked the related commit, and the code is missing an increment of i:

{code}
// In: solr/core/src/java/org/apache/solr/handler/SnapShooter.java

int i=1;
for(OldBackupDirectory dir : dirs) {
  if( i > numberToKeep-1 ) {
    SnapPuller.delTree(dir.dir);
  }
}   
{code}
                
> ReplicationHandler Backups -- clean up old backups
> --------------------------------------------------
>
>                 Key: SOLR-2578
>                 URL: https://issues.apache.org/jira/browse/SOLR-2578
>             Project: Solr
>          Issue Type: Improvement
>          Components: replication (java)
>    Affects Versions: 3.2, 4.0
>            Reporter: James Dyer
>            Assignee: James Dyer
>            Priority: Minor
>             Fix For: 3.5, 4.0
>
>         Attachments: SOLR-2578.patch, SOLR-2578.patch, SOLR-2578_3x.patch
>
>
> It would be nice when performing backups if there was an easy way to tell ReplicationHandler to only keep so many and then delete the older ones.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org