You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "dominikhei (via GitHub)" <gi...@apache.org> on 2025/07/16 22:12:21 UTC
[PR] Fix unreachable code errors in Vault provider [airflow]
dominikhei opened a new pull request, #53437:
URL: https://github.com/apache/airflow/pull/53437
---
related: https://github.com/apache/airflow/issues/53395
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix unreachable code errors in Vault provider [airflow]
Posted by "dominikhei (via GitHub)" <gi...@apache.org>.
dominikhei commented on code in PR #53437:
URL: https://github.com/apache/airflow/pull/53437#discussion_r2213828110
##########
providers/hashicorp/src/airflow/providers/hashicorp/secrets/vault.py:
##########
@@ -93,9 +93,9 @@ class VaultBackend(BaseSecretsBackend, LoggingMixin):
def __init__(
self,
- connections_path: str = "connections",
- variables_path: str = "variables",
- config_path: str = "config",
+ connections_path: str | None = "connections",
Review Comment:
I assumed they are nullable as in line 50 it says `(default: 'connections'). If set to None (null), requests for connections will not be sent to Vault.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix unreachable code errors in Vault provider [airflow]
Posted by "gopidesupavan (via GitHub)" <gi...@apache.org>.
gopidesupavan commented on code in PR #53437:
URL: https://github.com/apache/airflow/pull/53437#discussion_r2213825000
##########
providers/hashicorp/src/airflow/providers/hashicorp/secrets/vault.py:
##########
@@ -93,9 +93,9 @@ class VaultBackend(BaseSecretsBackend, LoggingMixin):
def __init__(
self,
- connections_path: str = "connections",
- variables_path: str = "variables",
- config_path: str = "config",
+ connections_path: str | None = "connections",
Review Comment:
does connection paths are optional i think atleast these are mandatory to work ?
cc: @amoghrajesh adding as you mostly worked related to connection any thoughts ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix unreachable code errors in Vault provider [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #53437:
URL: https://github.com/apache/airflow/pull/53437
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org