[GitHub] [druid] himanshug commented on a change in pull request #10551: Remove hard limitation that druid(after 0.15.0) only can consume Kafka version 0.11.x or better

[GitBox <gi...@apache.org>]

himanshug commented on a change in pull request #10551:
URL: https://github.com/apache/druid/pull/10551#discussion_r533827466



##########
File path: extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/KafkaConsumerConfigs.java
##########
@@ -31,14 +31,14 @@
 public class KafkaConsumerConfigs
 {
 
-  public static Map<String, Object> getConsumerProperties()
+  public static Map<String, Object> getConsumerProperties(Map<String, Object> customerConsumerProperties)

Review comment:
       it would likely be simpler to leave this alone, remove the line `props.put("isolation.level"..` altogether 
   
   and put something like ` props.put("isolation.level", customerConsumerProperties.getOrDefault("isolation.level", "read_committed"));`  right after https://github.com/apache/druid/blob/master/extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/supervisor/KafkaSupervisorIOConfig.java#L78




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org