You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "Patrick Rhomberg (JIRA)" <ji...@apache.org> on 2018/05/07 23:19:00 UTC

[jira] [Commented] (GEODE-5001) Update logj4 dependency to better integrate with Spring

    [ https://issues.apache.org/jira/browse/GEODE-5001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16466607#comment-16466607 ] 

Patrick Rhomberg commented on GEODE-5001:
-----------------------------------------

[~jblum] Regarding the relevance of the LOG4J2-2152, it seemed to be the cause some failing tests during a previous attempt to bump versions.  I vaguely remember the pressure being on Jackson, Jetty, and Spring, so not a great deal of effort was given to resolving the Log4j conflicts at the time.

For context, I believe GEODE-4030 was the ticket then, with [PR#1199|https://github.com/apache/geode/pull/1199] addressing that ticket and mentioning the failures in {{SessionReplicationIntegrationJUnitTest}} at either bump to 2.9.x or 2.10.x.

I've begun a precheckin based off PR#1741 (merged with develop), which uses 2.11.0.  Run locally, {{SessionReplicationIntegrationJUnitTest}} doesn't appear to fail.  If it clears precheckin, this should be able to be resolved directly, and if not, I can dig deeper into the conflicts.

> Update logj4 dependency to better integrate with Spring
> -------------------------------------------------------
>
>                 Key: GEODE-5001
>                 URL: https://issues.apache.org/jira/browse/GEODE-5001
>             Project: Geode
>          Issue Type: Improvement
>          Components: build, logging
>            Reporter: Anthony Baker
>            Assignee: Barbara Pruijn
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> The current geode log4j dependency is v2.8.2.  Spring (Boot, Data, etc) use log4j v2.11.0.  This make integration challenging.  We should upgrade our dependency to match Spring.  This will make it easier for our users to write geode applications.
> Checking for other updates using
> {noformat}
> gradle dependencyUpdates
> find . -name report.txt | xargs grep -e "\]$" | grep -v "org.apache.geode" | tr -s " " | cut -d' ' -f3- | sort | uniq | less
> {noformat}
> show that we have some other libraries that can be updated as well:
> {noformat}
> com.fasterxml.jackson.core:jackson-annotations [2.9.4 -> 2.9.5]
> com.fasterxml.jackson.core:jackson-core [2.9.4 -> 2.9.5]
> com.fasterxml.jackson.core:jackson-databind [2.9.4 -> 2.9.5]
> com.fasterxml.jackson.module:jackson-module-scala_2.10 [2.9.4 -> 2.9.5]
> com.google.guava:guava [24.0-jre -> 24.1-jre]
> com.google.protobuf:protoc [3.5.1 -> 3.5.1-1]
> com.zaxxer:HikariCP [2.7.6 -> 3.0.0]
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)