You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Armand Grillet <ag...@mesosphere.io> on 2017/09/03 08:33:59 UTC
Re: Review Request 60087: CLI: Added the ability for a plugin command
to have an alias.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60087/
-----------------------------------------------------------
(Updated Sept. 3, 2017, 8:33 a.m.)
Review request for mesos and Kevin Klues.
Repository: mesos
Description
-------
This will be used by future plugins.
Diffs (updated)
-----
src/python/cli_new/lib/cli/plugins/base.py edbe1ec3ce733faea0fd416c51a0884645da3dff
Diff: https://reviews.apache.org/r/60087/diff/2/
Changes: https://reviews.apache.org/r/60087/diff/1-2/
Testing
-------
Tested manually, PEP8 and Pylint used to make sure that the code style is correct.
Thanks,
Armand Grillet
Re: Review Request 60087: CLI: Added the ability for a plugin command
to have an alias.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60087/#review184466
-----------------------------------------------------------
Patch looks great!
Reviews applied: [60087]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Sept. 3, 2017, 1:33 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60087/
> -----------------------------------------------------------
>
> (Updated Sept. 3, 2017, 1:33 a.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This will be used by future plugins.
>
>
> Diffs
> -----
>
> src/python/cli_new/lib/cli/plugins/base.py edbe1ec3ce733faea0fd416c51a0884645da3dff
>
>
> Diff: https://reviews.apache.org/r/60087/diff/2/
>
>
> Testing
> -------
>
> Tested manually, PEP8 and Pylint used to make sure that the code style is correct.
>
>
> Thanks,
>
> Armand Grillet
>
>