You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@couchdb.apache.org by hdiedrich <gi...@git.apache.org> on 2014/11/14 17:13:40 UTC

[GitHub] couchdb-snappy pull request: Exclude ComputeTable from building

GitHub user hdiedrich opened a pull request:

    https://github.com/apache/couchdb-snappy/pull/1

    Exclude ComputeTable from building

    Set NDEBUG as CXXFLAGS to skip the compilation of this debug function.
    
    The NDEBUG logic is broken because REGISTER_MODULE_INITIALIZER(snappy,
    ComputeTable()); is set to always result to nothing, independently of
    NDEBUG.
    
    If debug tests should instead be included in the build, both NDEBUG
    must not be set (as before) but also, REGISTER_MODULE_INITIALIZER
    repaired.
    
    COUCHDB-2463

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hdiedrich/couchdb-snappy 2463-exclude-debug-function-computetable

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-snappy/pull/1.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1
    
----
commit 80e7c4f23b25138d8670b16df3185f7960b25af4
Author: H. Diedrich <hd...@eonblast.com>
Date:   2014-11-14T15:52:09Z

    Exclude ComputeTable from building
    
    Set NDEBUG as CXXFLAGS to skip the compilation of this debug function.
    
    The NDEBUG logic is broken because REGISTER_MODULE_INITIALIZER(snappy,
    ComputeTable()); is set to always result to nothing, independently of
    NDEBUG.
    
    If debug tests should instead be included in the build, both NDEBUG
    must not be set (as before) but also, REGISTER_MODULE_INITIALIZER
    repaired.
    
    COUCHDB-2463

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-snappy pull request: Exclude ComputeTable from building

Posted by kxepal <gi...@git.apache.org>.

Github user kxepal commented on the pull request:

    https://github.com/apache/couchdb-snappy/pull/1#issuecomment-63872273
  
    It landed without problems at [b344f95](https://git-wip-us.apache.org/repos/asf?p=couchdb-snappy.git;h=b344f95). You may close this PR now. Thanks! (:


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-snappy pull request: Exclude ComputeTable from building

Posted by kxepal <gi...@git.apache.org>.

Github user kxepal commented on the pull request:

    https://github.com/apache/couchdb-snappy/pull/1#issuecomment-63731015
  
    Thanks for the PR, but we need first to define master branch since current ones (import-master and 1994-merge-rcouch) were created during initial repository split up and forks merge. Also they are out of sync - import-master contains more recent version of snappy. 
    
    Once we sort this out, we'll ask you to rebase and update PR. Keep it open for now as a reminder.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-snappy pull request: Exclude ComputeTable from building

Posted by hdiedrich <gi...@git.apache.org>.

Github user hdiedrich commented on the pull request:

    https://github.com/apache/couchdb-snappy/pull/1#issuecomment-63735173
  
    Sure, thx.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-snappy pull request: Exclude ComputeTable from building

Posted by hdiedrich <gi...@git.apache.org>.

Github user hdiedrich closed the pull request at:

    https://github.com/apache/couchdb-snappy/pull/1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---