You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/02 19:42:23 UTC
[GitHub] [arrow-rs] heyrutvik opened a new pull request, #1992: Implements Into for T: Array
heyrutvik opened a new pull request, #1992:
URL: https://github.com/apache/arrow-rs/pull/1992
# Which issue does this PR close?
Closes #1979
# Rationale for this change
The method `into_data` is a cheaper alternative to the more pervasive `.data().clone()` calls to get underlying array data. It's cheaper since it doesn't clone anything but returns already allocated data (except for `ArrayRef`).
# What changes are included in this PR?
It implements `Into` indirectly to convert specific array type to general one.
# Are there any user-facing changes?
It adds `fn into_data(self) -> ArrayData` method to `Array` trait.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #1992: Implements Into for T: Array
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #1992:
URL: https://github.com/apache/arrow-rs/pull/1992#issuecomment-1178085740
Thanks @heyrutvik
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on pull request #1992: Implements Into for T: Array
Posted by GitBox <gi...@apache.org>.
tustvold commented on PR #1992:
URL: https://github.com/apache/arrow-rs/pull/1992#issuecomment-1173680766
I'm going to say this isn't a breaking change, as whilst technically Array can be implemented outside this crate, practically the use of as_any means it can't be
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #1992: Implements Into for T: Array
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1992:
URL: https://github.com/apache/arrow-rs/pull/1992#issuecomment-1172995294
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1992?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1992](https://codecov.io/gh/apache/arrow-rs/pull/1992?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f3e0768) into [master](https://codecov.io/gh/apache/arrow-rs/commit/7ae97c9cebabf757275e41587fe4e3dbdf38d4ab?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7ae97c9) will **decrease** coverage by `0.00%`.
> The diff coverage is `89.14%`.
```diff
@@ Coverage Diff @@
## master #1992 +/- ##
==========================================
- Coverage 83.58% 83.57% -0.01%
==========================================
Files 222 222
Lines 57495 57542 +47
==========================================
+ Hits 48056 48090 +34
- Misses 9439 9452 +13
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/1992?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [arrow/src/array/array\_decimal.rs](https://codecov.io/gh/apache/arrow-rs/pull/1992/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2FycmF5X2RlY2ltYWwucnM=) | `92.88% <0.00%> (-0.79%)` | :arrow_down: |
| [.../src/array/builder/primitive\_dictionary\_builder.rs](https://codecov.io/gh/apache/arrow-rs/pull/1992/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2J1aWxkZXIvcHJpbWl0aXZlX2RpY3Rpb25hcnlfYnVpbGRlci5ycw==) | `78.68% <ø> (ø)` | |
| [integration-testing/src/lib.rs](https://codecov.io/gh/apache/arrow-rs/pull/1992/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZWdyYXRpb24tdGVzdGluZy9zcmMvbGliLnJz) | `0.00% <0.00%> (ø)` | |
| [arrow/src/array/array\_union.rs](https://codecov.io/gh/apache/arrow-rs/pull/1992/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2FycmF5X3VuaW9uLnJz) | `90.14% <20.00%> (-0.78%)` | :arrow_down: |
| [arrow/src/array/array\_map.rs](https://codecov.io/gh/apache/arrow-rs/pull/1992/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2FycmF5X21hcC5ycw==) | `83.07% <55.55%> (-1.74%)` | :arrow_down: |
| [arrow/src/json/reader.rs](https://codecov.io/gh/apache/arrow-rs/pull/1992/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2pzb24vcmVhZGVyLnJz) | `84.58% <77.77%> (ø)` | |
| [arrow/src/array/array.rs](https://codecov.io/gh/apache/arrow-rs/pull/1992/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2FycmF5LnJz) | `92.05% <83.33%> (-0.16%)` | :arrow_down: |
| [arrow/src/array/array\_binary.rs](https://codecov.io/gh/apache/arrow-rs/pull/1992/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2FycmF5X2JpbmFyeS5ycw==) | `94.29% <100.00%> (+0.08%)` | :arrow_up: |
| [arrow/src/array/array\_boolean.rs](https://codecov.io/gh/apache/arrow-rs/pull/1992/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2FycmF5X2Jvb2xlYW4ucnM=) | `93.38% <100.00%> (+0.20%)` | :arrow_up: |
| [arrow/src/array/array\_dictionary.rs](https://codecov.io/gh/apache/arrow-rs/pull/1992/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2FycmF5X2RpY3Rpb25hcnkucnM=) | `92.06% <100.00%> (+0.12%)` | :arrow_up: |
| ... and [25 more](https://codecov.io/gh/apache/arrow-rs/pull/1992/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1992?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1992?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7ae97c9...f3e0768](https://codecov.io/gh/apache/arrow-rs/pull/1992?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #1992: Implements Into for T: Array
Posted by GitBox <gi...@apache.org>.
tustvold merged PR #1992:
URL: https://github.com/apache/arrow-rs/pull/1992
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org