You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by kayousterhout <gi...@git.apache.org> on 2017/02/03 20:27:38 UTC

[GitHub] spark issue #16738: [SPARK-19398] Change one misleading log in TaskSetManage...

Github user kayousterhout commented on the issue:

    https://github.com/apache/spark/pull/16738
  
    I'd prefer to just change the log message and not rename successful to completed -- which I think is too ambiguous with tasks that have "completed" in the sense that they've failed (if we're going to do that change, I think there should be a bigger change to change all of the uses of successful to be consistent and to add better commenting, which is beyond the scope of this log-change PR).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org