You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/11/26 03:39:58 UTC
[GitHub] [iotdb] HTHou opened a new pull request, #8184: Optimize insert statement generate
HTHou opened a new pull request, #8184:
URL: https://github.com/apache/iotdb/pull/8184
## Description
Optimize tsbs insert performance.
set wal_mode=DISABLE
Before:
```
Summary:
loaded 78537600 metrics in 92.089sec with 1 workers (mean rate 852844.44 metrics/sec)
loaded 6998400 rows in 92.089sec with 1 workers (mean rate 75996.04 rows/sec)
```
After
```
loaded 78537600 metrics in 29.084sec with 1 workers (mean rate 2700401.36 metrics/sec)
loaded 6998400 rows in 29.084sec with 1 workers (mean rate 240629.82 rows/sec)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou closed pull request #8184: Optimize insert statement generate
Posted by GitBox <gi...@apache.org>.
HTHou closed pull request #8184: Optimize insert statement generate
URL: https://github.com/apache/iotdb/pull/8184
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] MarcosZyk commented on a diff in pull request #8184: Optimize insert statement generate
Posted by GitBox <gi...@apache.org>.
MarcosZyk commented on code in PR #8184:
URL: https://github.com/apache/iotdb/pull/8184#discussion_r1032735772
##########
server/src/main/java/org/apache/iotdb/db/mpp/plan/parser/StatementGenerator.java:
##########
@@ -232,9 +232,12 @@ public static Statement createStatement(TSInsertTabletsReq req) throws IllegalPa
// construct insert statement
InsertMultiTabletsStatement insertStatement = new InsertMultiTabletsStatement();
List<InsertTabletStatement> insertTabletStatementList = new ArrayList<>();
+ Map<String, PartialPath> devicePathMap = new HashMap<>();
for (int i = 0; i < req.prefixPaths.size(); i++) {
InsertTabletStatement insertTabletStatement = new InsertTabletStatement();
- insertTabletStatement.setDevicePath(new PartialPath(req.prefixPaths.get(i)));
+ insertTabletStatement.setDevicePath(
+ devicePathMap.putIfAbsent(
Review Comment:
Should this be ```computeIfAbsent```?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8184: Optimize insert statement generate
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #8184:
URL: https://github.com/apache/iotdb/pull/8184#issuecomment-1327973601
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_incubator-iotdb&pullRequest=8184)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8184&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8184&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8184&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8184&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8184&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8184&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=8184&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=8184&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=8184&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8184&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8184&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8184&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=8184&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=8184&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=8184&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=8184&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org