[jira] [Comment Edited] (CASSANDRA-7384) Collect metrics on queries by consistency level

["Robert Stupp (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-7384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15378877#comment-15378877 ] 

Robert Stupp edited comment on CASSANDRA-7384 at 7/15/16 5:19 AM:
------------------------------------------------------------------

Generally LGTM - just a one comment:
* we use {{.}} as a separator throughout the metrics. Would be nicer to use a {{.}} instead of {{\-}} for the metric names (in the constructor initializing the metric maps - e.g. {{new ClientRequestMetrics("Read-" + level.name())}})

If you're fine, I can fix that on commit.


was (Author: snazy):
Generally LGTM - just a one comment:
* we use {{.}} as a separator throughout the metrics. Would be nicer to use a {{.}} instead of {{-}} for the metric names (in the constructor initializing the metric maps - e.g. {{new ClientRequestMetrics("Read-" + level.name())}})

If you're fine, I can fix that on commit.

> Collect metrics on queries by consistency level
> -----------------------------------------------
>
>                 Key: CASSANDRA-7384
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7384
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Vishy Kasar
>            Assignee: sankalp kohli
>            Priority: Minor
>             Fix For: 3.x
>
>         Attachments: CASSANDRA-7384_3.0_v2.txt
>
>
> We had cases where cassandra client users thought that they were doing queries at one consistency level but turned out to be not correct. It will be good to collect metrics on number of queries done at various consistency level on the server. See the equivalent JIRA on java driver: https://datastax-oss.atlassian.net/browse/JAVA-354



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)