You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/09/16 03:41:51 UTC

[GitHub] [camel-k] tadayosi opened a new pull request, #3651: chore(ci): experimental use of gotestfmt for e2e

tadayosi opened a new pull request, #3651:
URL: https://github.com/apache/camel-k/pull/3651

   <!-- Description -->
   
   
   
   
   <!--
   Enter your extended release note in the below block. If the PR requires
   additional action from users switching to the new release, include the string
   "action required". If no release note is required, write "NONE". 
   
   You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
   the text is added to the right section of the release notes. 
   -->
   
   **Release Note**
   ```release-note
   NONE
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] tadayosi commented on a diff in pull request #3651: chore(ci): experimental use of gotestfmt for e2e

Posted by GitBox <gi...@apache.org>.
tadayosi commented on code in PR #3651:
URL: https://github.com/apache/camel-k/pull/3651#discussion_r979611233


##########
script/Makefile:
##########
@@ -246,55 +246,60 @@ test: do-build
 # Note
 # This should execute all tests and not exit if one of the suites fail
 #
-test-integration: do-build
+test-integration: do-build gotestfmt-install

Review Comment:
   It was because `gotestfmt-install` is used only for testing. But agreed that by putting it to `do-build` will make Makefile less cluttered. I'll change it accordingly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] tadayosi merged pull request #3651: chore(ci): experimental use of gotestfmt for e2e

Posted by GitBox <gi...@apache.org>.
tadayosi merged PR #3651:
URL: https://github.com/apache/camel-k/pull/3651


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] squakez commented on a diff in pull request #3651: chore(ci): experimental use of gotestfmt for e2e

Posted by GitBox <gi...@apache.org>.
squakez commented on code in PR #3651:
URL: https://github.com/apache/camel-k/pull/3651#discussion_r973946161


##########
script/Makefile:
##########
@@ -246,55 +246,60 @@ test: do-build
 # Note
 # This should execute all tests and not exit if one of the suites fail
 #
-test-integration: do-build
+test-integration: do-build gotestfmt-install

Review Comment:
   Why not to put `gotestfmt-install`as part of the `do-build` procedure?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] tadayosi commented on pull request #3651: chore(ci): experimental use of gotestfmt for e2e

Posted by GitBox <gi...@apache.org>.
tadayosi commented on PR #3651:
URL: https://github.com/apache/camel-k/pull/3651#issuecomment-1257737692

   OK, lets merge it then. The CI failure is rather a demonstration for the output and must have nothing to do with the PR itself.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org