[GitHub] incubator-hawq pull request #1002: HAWQ-1130. Make HCatalog integration work...

[shivzone <gi...@git.apache.org>]

Github user shivzone commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/1002#discussion_r88303706
  
    --- Diff: src/backend/access/transam/varsup.c ---
    @@ -408,6 +409,9 @@ GetNewExternalObjectId(void)
     	/*
     	 * must perform check on External Oid range on
     	 * initial access of NextExternalOid
    +	 *
    +	 * It's needed for upgrade scenario from old version
    +	 * of HAWQ which doesn't support dedicated oid pool for HCatalog objects
     	 */
     	if (!IsExternalOidInitialized)
     	{
    --- End diff --
    
    Can refactor this 
    if(master_highest_used_oid() < FirstExternalObjectId)
    {
        ResetExternalObjectId;
    }
    else
    {
        ereport(....);
    }


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---