[GitHub] [calcite] hsyuan commented on a change in pull request #1604: [CALCITE-3521] CalciteSystemProperty failed to load config file

[GitBox <gi...@apache.org>]

hsyuan commented on a change in pull request #1604: [CALCITE-3521] CalciteSystemProperty failed to load config file
URL: https://github.com/apache/calcite/pull/1604#discussion_r350999946
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/config/CalciteSystemProperty.java
 ##########
 @@ -368,9 +369,11 @@
 
   private static Properties loadProperties() {
     Properties saffronProperties = new Properties();
+    ClassLoader classLoader = MoreObjects.firstNonNull(
+        Thread.currentThread().getContextClassLoader(),
+        CalciteSystemProperty.class.getClassLoader());
     // Read properties from the file "saffron.properties", if it exists in classpath
 
 Review comment:
   I am not too concerned about this, since Log4J uses the same way to load configuration file.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services