[jira] [Commented] (PROTON-427) settle does not match accept/reject for ruby

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PROTON-427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776587#comment-13776587 ] 

ASF subversion and git services commented on PROTON-427:
--------------------------------------------------------

Commit 1525959 from [~mcpierce] in branch 'proton/trunk'
[ https://svn.apache.org/r1525959 ]

PROTON-427: Removed the flag argument from Messenger.settle

Made the API more consistent with the accept and reject methods.
                
> settle does not match accept/reject for ruby
> --------------------------------------------
>
>                 Key: PROTON-427
>                 URL: https://issues.apache.org/jira/browse/PROTON-427
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: proton-c
>    Affects Versions: 0.5
>            Reporter: Gordon Sim
>            Assignee: Darryl L. Pierce
>
> In 0.4 the ruby versions of accept()/reject() and settle() all took a tracker and flags (and both were required)
> In 0.5 this was changed for accept/reject. Only one argument could be passed, the tracker, and it was optional. However settle remains the same as before which seems inconsistent. (Of course changing it now would break the API again between 0.5 and the next release).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira