[GitHub] [incubator-yunikorn-k8shim] kingamarton edited a comment on pull request #202: [YUNIKORN-449] Added MatchNodeSelectorPred to reservation predicates list

[GitBox <gi...@apache.org>]

kingamarton edited a comment on pull request #202:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/202#issuecomment-717516148


   > Hi @kingamarton thanks for testing this out.
   > 
   > > so I extended the predicate list for the default scheduling policy as well.
   > 
   > If this is added to the `defaultSchedulerPolicy` list, it will be overlapping with `predicates.GeneralPred`. If you follow the code traces, you'll see `predicates.GeneralPred` calls `PodMatchNodeSelector`. That means while it tries to `predicatesAllocate()`, it runs the node-selector twice.
   > 
   > I guess we need to fix some other way round. The problem you met might be caused by the CLI parser. Please take a look at #64. It adds the support to give a configurable list of predicates in CLI options. I think the fix here is, when the CLI is not providing any input, the default ones should come from both `defaultSchedulerPolicy` and `reservationPredicates`. Please let me know your thought about this.
   > 
   > Thanks
   
   @yangwwei I thought about how we can solve this issue. What we discussed offline: to have an another list with the allocationPredicates and registering the reservation predicates as well, might not work, because if there are some predicates passed in the CLI, we might end in checking some extra predicates for a reservation than for the allocation. 
   
   Instead of this, I expanded the GeneralPredicate and added each predicate separately. I skipped one: PodFitsPorts, what has been replaced by PodFitsHostPorts, and since we don't support K8s 1.0, I think we don't need that.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org