[GitHub] [hudi] xushiyan commented on a diff in pull request #6824: [HUDI-4946] fix merge into with no preCombineField has dup row by onl…

[GitBox <gi...@apache.org>]

xushiyan commented on code in PR #6824:
URL: https://github.com/apache/hudi/pull/6824#discussion_r999328075


##########
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/MergeIntoHoodieTableCommand.scala:
##########
@@ -160,7 +167,7 @@ case class MergeIntoHoodieTableCommand(mergeInto: MergeIntoTable) extends Hoodie
 
       // column order changed after left anti join , we should keep column order of source dataframe
       val cols = removeMetaFields(sourceDF).columns
-      executeInsertOnly(insertSourceDF.select(cols.head, cols.tail:_*), parameters)
+      executeInsertOnly(insertSourceDF.select(cols.head, cols.tail:_*), writeParam)

Review Comment:
   this is basically saying if user sets precombine field, we always upsert, even if there's no match. i don't think this is the right semantics. if you want to de-duplicate the incoming records, then use `hoodie.combine.before.insert`. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org