You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2020/03/24 19:08:51 UTC
[kudu-CR] Replace 'null bitmap' variable names with 'non null bitmap'
Hello Andrew Wong,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/15548
to review the following change.
Change subject: Replace 'null_bitmap' variable names with 'non_null_bitmap'
......................................................................
Replace 'null_bitmap' variable names with 'non_null_bitmap'
These bitmaps have always had the semantics that a set bit indicated a
non-null entry. Thus the name 'null_bitmap' was misleading. This is a
simple find/replace to 'non_null_bitmap'.
Notably the code in CFileWriter::AppendNullableEntries now makes a lot
more sense.
Change-Id: Ie67dea54ce41ea42a7de5640845e402ac98ee3ce
---
M src/kudu/cfile/cfile-test-base.h
M src/kudu/cfile/cfile-test.cc
M src/kudu/cfile/cfile_reader.cc
M src/kudu/cfile/cfile_writer.cc
M src/kudu/cfile/cfile_writer.h
M src/kudu/client/write_op.cc
M src/kudu/common/column_predicate.cc
M src/kudu/common/columnblock.cc
M src/kudu/common/columnblock.h
M src/kudu/common/partial_row.cc
M src/kudu/common/row.h
M src/kudu/common/row_operations.cc
M src/kudu/common/row_operations.h
M src/kudu/common/rowblock.cc
M src/kudu/common/rowblock.h
M src/kudu/common/wire_protocol-test.cc
M src/kudu/common/wire_protocol.cc
M src/kudu/integration-tests/all_types-itest.cc
M src/kudu/tablet/multi_column_writer.cc
M src/kudu/tablet/tablet-test-util.h
20 files changed, 92 insertions(+), 87 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/48/15548/1
--
To view, visit http://gerrit.cloudera.org:8080/15548
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie67dea54ce41ea42a7de5640845e402ac98ee3ce
Gerrit-Change-Number: 15548
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Andrew Wong <an...@cloudera.com>
[kudu-CR] Replace 'null bitmap' variable names with 'non null bitmap'
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15548 )
Change subject: Replace 'null_bitmap' variable names with 'non_null_bitmap'
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Test failure is a known flake, but IWYU is unhappy.
http://gerrit.cloudera.org:8080/#/c/15548/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/15548/1//COMMIT_MSG@13
PS1, Line 13: Notably the code in CFileWriter::AppendNullableEntries now makes a lot
: more sense.
Nice
--
To view, visit http://gerrit.cloudera.org:8080/15548
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie67dea54ce41ea42a7de5640845e402ac98ee3ce
Gerrit-Change-Number: 15548
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Andrew Wong <an...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 24 Mar 2020 19:56:55 +0000
Gerrit-HasComments: Yes
[kudu-CR] Replace 'null bitmap' variable names with 'non null bitmap'
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15548 )
Change subject: Replace 'null_bitmap' variable names with 'non_null_bitmap'
......................................................................
Replace 'null_bitmap' variable names with 'non_null_bitmap'
These bitmaps have always had the semantics that a set bit indicated a
non-null entry. Thus the name 'null_bitmap' was misleading. This is a
simple find/replace to 'non_null_bitmap'.
Notably the code in CFileWriter::AppendNullableEntries now makes a lot
more sense.
Change-Id: Ie67dea54ce41ea42a7de5640845e402ac98ee3ce
Reviewed-on: http://gerrit.cloudera.org:8080/15548
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Tested-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/cfile/cfile-test-base.h
M src/kudu/cfile/cfile-test.cc
M src/kudu/cfile/cfile_reader.cc
M src/kudu/cfile/cfile_writer.cc
M src/kudu/cfile/cfile_writer.h
M src/kudu/client/write_op.cc
M src/kudu/common/column_predicate.cc
M src/kudu/common/columnblock.cc
M src/kudu/common/columnblock.h
M src/kudu/common/partial_row.cc
M src/kudu/common/row.h
M src/kudu/common/row_operations.cc
M src/kudu/common/row_operations.h
M src/kudu/common/rowblock.cc
M src/kudu/common/rowblock.h
M src/kudu/common/wire_protocol-test.cc
M src/kudu/common/wire_protocol.cc
M src/kudu/integration-tests/all_types-itest.cc
M src/kudu/tablet/multi_column_writer.cc
M src/kudu/tablet/tablet-test-util.h
20 files changed, 92 insertions(+), 87 deletions(-)
Approvals:
Andrew Wong: Looks good to me, approved
Todd Lipcon: Verified
--
To view, visit http://gerrit.cloudera.org:8080/15548
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie67dea54ce41ea42a7de5640845e402ac98ee3ce
Gerrit-Change-Number: 15548
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Andrew Wong <an...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Replace 'null bitmap' variable names with 'non null bitmap'
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has removed a vote on this change.
Change subject: Replace 'null_bitmap' variable names with 'non_null_bitmap'
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/15548
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ie67dea54ce41ea42a7de5640845e402ac98ee3ce
Gerrit-Change-Number: 15548
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Andrew Wong <an...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Replace 'null bitmap' variable names with 'non null bitmap'
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15548 )
Change subject: Replace 'null_bitmap' variable names with 'non_null_bitmap'
......................................................................
Patch Set 1: Verified+1
I'm gonna override IWYU for now since I didn't change anything that affects includes, and Adar's just about to commit some changes to fix all the remaining problems.
--
To view, visit http://gerrit.cloudera.org:8080/15548
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie67dea54ce41ea42a7de5640845e402ac98ee3ce
Gerrit-Change-Number: 15548
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Andrew Wong <an...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 24 Mar 2020 20:05:36 +0000
Gerrit-HasComments: No