You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/03/09 05:51:52 UTC
[GitHub] [incubator-iotdb-website] SailVR opened a new pull request #66: [IOTDB-521]改为访问本地文件，优化首页界面
SailVR opened a new pull request #66: [IOTDB-521]改为访问本地文件，优化首页界面
URL: https://github.com/apache/incubator-iotdb-website/pull/66
0.8/0.9版本为访问本地html，in progress版本为访问本地md文件
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb-website] samperson1997 commented on a change in pull request #66: [IOTDB-521]改为访问本地文件，优化首页界面
Posted by GitBox <gi...@apache.org>.
samperson1997 commented on a change in pull request #66: [IOTDB-521]改为访问本地文件，优化首页界面
URL: https://github.com/apache/incubator-iotdb-website/pull/66#discussion_r389475834
##########
File path: src/views/SystemDesign.vue
##########
@@ -43,10 +43,7 @@
class="go-to-development" @click="goToDevelopment()">Go for it.</span></p>
</div>
<div class="doc-footer">
- <p style="color: #AAA">
- Disclaimer: Apache IoTDB (incubating) (Database for Internet of Things) is an effort undergoing incubation at The Apache Software Foundation (ASF), sponsored by the Apache Incubator. Incubation is required of all newly accepted projects until a further review indicates that the infrastructure, communications, and decision making process have stabilized in a manner consistent with other successful ASF projects. While incubation status is not necessarily a reflection of the completeness or stability of the code, it does indicate that the project has yet to be fully endorsed by the ASF.
- </p>
- <span style="text-align: center">Copyright © 2020 The Apache Software Foundation. Apache and the Apache feather logo are trademarks of The Apache Software Foundation.</span>
+ <span>Copyright © 2019 The Apache Software Foundation. Apache and the Apache feather logo are trademarks of The Apache Software Foundation.</span>
Review comment:
```suggestion
<span>Copyright © 2020 The Apache Software Foundation. Apache and the Apache feather logo are trademarks of The Apache Software Foundation.</span>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb-website] samperson1997 commented on a change in pull request #66: [IOTDB-521]改为访问本地文件，优化首页界面
Posted by GitBox <gi...@apache.org>.
samperson1997 commented on a change in pull request #66: [IOTDB-521]改为访问本地文件，优化首页界面
URL: https://github.com/apache/incubator-iotdb-website/pull/66#discussion_r389474376
##########
File path: src/components/NavBar.vue
##########
@@ -123,14 +113,6 @@
{"url": "/Development/Tsfile", "content": "Changelist of TsFile"},
{"url": "/Development/RPC", "content": "Changelist of RPC"}
],
- "ASF": [
- {"url":"http://www.apache.org/foundation/","content":"Foundation"},
- {"url":"http://www.apache.org/licenses/","content":"License"},
- {"url":"http://www.apache.org/security/","content":"Security"},
- {"url":"http://www.apache.org/foundation/sponsorship.html","content":"Sponsorship"},
- {"url":"http://www.apache.org/foundation/thanks.html","content":"Thanks"},
- {"url":"http://www.apache.org/events/current-event","content":"Current Events"},
- ],
defaultDocLink: "/Documents/" + Global.DEFAULT_VERSION + "/chap1/sec1",
Review comment:
Don't delete this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb-website] samperson1997 commented on a change in pull request #66: [IOTDB-521]改为访问本地文件，优化首页界面
Posted by GitBox <gi...@apache.org>.
samperson1997 commented on a change in pull request #66: [IOTDB-521]改为访问本地文件，优化首页界面
URL: https://github.com/apache/incubator-iotdb-website/pull/66#discussion_r389474973
##########
File path: src/views/Documents.vue
##########
@@ -37,16 +37,18 @@
</ul>
<div class="text-field" id="text-content">
<language-button :eng="eng" @click.native="switchLanguage()"/>
- <vue-markdown class="markdown-area" :source="document" :toc="true" :toc-anchor-link="true"
+ <vue-markdown v-show="!ok" class="markdown-area" :source="document" :toc="true" :toc-anchor-link="true"
toc-anchor-link-symbol=""></vue-markdown>
- <p class="find-mistake">This documentation is open source. Find mistakes? Want to contribute? <span
+
+ <p class="find-mistake" v-show="!ok">This documentation is open source. Find mistakes? Want to contribute? <span
class="go-to-development" @click="goToDevelopment()">Go for it.</span></p>
+
+ <iframe :src="solidhtml" v-show="ok" style="margin:0;padding:0;align:middle;width: 800px;height:600px;border:none; overflow-x:hidden; overflow-y:hidden;"></iframe>
+
</div>
+
<div class="doc-footer">
- <p style="color: #AAA">
- Disclaimer: Apache IoTDB (incubating) (Database for Internet of Things) is an effort undergoing incubation at The Apache Software Foundation (ASF), sponsored by the Apache Incubator. Incubation is required of all newly accepted projects until a further review indicates that the infrastructure, communications, and decision making process have stabilized in a manner consistent with other successful ASF projects. While incubation status is not necessarily a reflection of the completeness or stability of the code, it does indicate that the project has yet to be fully endorsed by the ASF.
- </p>
- <span style="text-align: center">Copyright © 2020 The Apache Software Foundation. Apache and the Apache feather logo are trademarks of The Apache Software Foundation.</span>
+ <span>Copyright © 2019 The Apache Software Foundation. Apache and the Apache feather logo are trademarks of The Apache Software Foundation.</span>
Review comment:
```suggestion
<span>Copyright © 2020 The Apache Software Foundation. Apache and the Apache feather logo are trademarks of The Apache Software Foundation.</span>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb-website] samperson1997 commented on issue #66: [IOTDB-521]改为访问本地文件，优化首页界面
Posted by GitBox <gi...@apache.org>.
samperson1997 commented on issue #66: [IOTDB-521]改为访问本地文件，优化首页界面
URL: https://github.com/apache/incubator-iotdb-website/pull/66#issuecomment-596495694
New PR #67
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb-website] samperson1997 commented on a change in pull request #66: [IOTDB-521]改为访问本地文件，优化首页界面
Posted by GitBox <gi...@apache.org>.
samperson1997 commented on a change in pull request #66: [IOTDB-521]改为访问本地文件，优化首页界面
URL: https://github.com/apache/incubator-iotdb-website/pull/66#discussion_r389475790
##########
File path: src/views/SingleTool.vue
##########
@@ -0,0 +1,119 @@
+<template>
Review comment:
Delete this file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb-website] samperson1997 commented on a change in pull request #66: [IOTDB-521]改为访问本地文件，优化首页界面
Posted by GitBox <gi...@apache.org>.
samperson1997 commented on a change in pull request #66: [IOTDB-521]改为访问本地文件，优化首页界面
URL: https://github.com/apache/incubator-iotdb-website/pull/66#discussion_r389474329
##########
File path: src/components/NavBar.vue
##########
@@ -59,16 +59,6 @@
</li>
</ul>
</li>
- <li class="dropdown">
- <router-link to="/Community/Powered By" class="dropdown-toggle" data-toggle="dropdown" role="button"
- aria-haspopup="true" aria-expanded="false"><span>ASF<b class="caret"></b></span>
- </router-link>
- <ul class="dropdown-menu">
- <li v-for="item in ASF">
- <a :href=item.url :class="nav-link"><span>{{item.content}}</span></a>
- </li>
- </ul>
- </li>
Review comment:
Don't delete this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb-website] samperson1997 commented on a change in pull request #66: [IOTDB-521]改为访问本地文件，优化首页界面
Posted by GitBox <gi...@apache.org>.
samperson1997 commented on a change in pull request #66: [IOTDB-521]改为访问本地文件，优化首页界面
URL: https://github.com/apache/incubator-iotdb-website/pull/66#discussion_r389475254
##########
File path: src/views/Documents.vue
##########
@@ -162,23 +166,61 @@
if (version === "0.8.x") {
chapter -= 1
}
+ if (version === "0.8.x" || version === "0.9.x") {
+ this.ok = true;
+ }else{
+ this.ok = false;
+ }
let section = Number(this.getSection().substr(3));
+ // var lang = navigator.language||navigator.userLanguage;//常规浏览器语言和IE浏览器
+ // lang = lang.substr(0, 2);//截取lang前2位字符
+
Review comment:
Remove comments (and also other parts in this file)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb-website] samperson1997 commented on a change in pull request #66: [IOTDB-521]改为访问本地文件，优化首页界面
Posted by GitBox <gi...@apache.org>.
samperson1997 commented on a change in pull request #66: [IOTDB-521]改为访问本地文件，优化首页界面
URL: https://github.com/apache/incubator-iotdb-website/pull/66#discussion_r389474879
##########
File path: src/router/index.js
##########
@@ -33,6 +41,16 @@ export default new Router({
name: 'SystemDesignDocuments',
component: SystemDesign
},
+ {
+ path: '/Tools',
+ name: 'Tools',
+ component: Tools
+ },
+ {
+ path: '/Tools/:content',
+ name: 'SingleTool',
+ component: SingleTool
+ },
Review comment:
Delete this useless components and the related import
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb-website] samperson1997 commented on a change in pull request #66: [IOTDB-521]改为访问本地文件，优化首页界面
Posted by GitBox <gi...@apache.org>.
samperson1997 commented on a change in pull request #66: [IOTDB-521]改为访问本地文件，优化首页界面
URL: https://github.com/apache/incubator-iotdb-website/pull/66#discussion_r389475637
##########
File path: src/views/Download.vue
##########
@@ -38,7 +38,7 @@
verify
hashes and signatures </a> which you can follow by using any of these
release-signing <a class="link-color"
- href="https://downloads.apache.org/incubator/iotdb/KEYS">
+ href="https://www.apache.org/dist/incubator/iotdb/KEYS">
Review comment:
Use `downloads.apache.org` instead of `www.apache.org/dist`
And also all download links in this file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb-website] samperson1997 closed pull request #66: [IOTDB-521]改为访问本地文件，优化首页界面
Posted by GitBox <gi...@apache.org>.
samperson1997 closed pull request #66: [IOTDB-521]改为访问本地文件，优化首页界面
URL: https://github.com/apache/incubator-iotdb-website/pull/66
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb-website] samperson1997 commented on a change in pull request #66: [IOTDB-521]改为访问本地文件，优化首页界面
Posted by GitBox <gi...@apache.org>.
samperson1997 commented on a change in pull request #66: [IOTDB-521]改为访问本地文件，优化首页界面
URL: https://github.com/apache/incubator-iotdb-website/pull/66#discussion_r389475391
##########
File path: src/views/Documents.vue
##########
@@ -307,7 +350,7 @@
margin-bottom: 5px;
padding: 5px;
max-width: 80%;
- line-height: 15px;
Review comment:
Don't delete this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb-website] samperson1997 commented on a change in pull request #66: [IOTDB-521]改为访问本地文件，优化首页界面
Posted by GitBox <gi...@apache.org>.
samperson1997 commented on a change in pull request #66: [IOTDB-521]改为访问本地文件，优化首页界面
URL: https://github.com/apache/incubator-iotdb-website/pull/66#discussion_r389475877
##########
File path: src/views/Tools.vue
##########
@@ -0,0 +1,253 @@
+<template>
Review comment:
Delete this file
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb-website] samperson1997 commented on a change in pull request #66: [IOTDB-521]改为访问本地文件，优化首页界面
Posted by GitBox <gi...@apache.org>.
samperson1997 commented on a change in pull request #66: [IOTDB-521]改为访问本地文件，优化首页界面
URL: https://github.com/apache/incubator-iotdb-website/pull/66#discussion_r389475857
##########
File path: src/views/SystemDesign.vue
##########
@@ -307,7 +304,7 @@
margin-bottom: 5px;
padding: 5px;
max-width: 80%;
- line-height: 15px;
Review comment:
Don't remove this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb-website] samperson1997 commented on a change in pull request #66: [IOTDB-521]改为访问本地文件，优化首页界面
Posted by GitBox <gi...@apache.org>.
samperson1997 commented on a change in pull request #66: [IOTDB-521]改为访问本地文件，优化首页界面
URL: https://github.com/apache/incubator-iotdb-website/pull/66#discussion_r389474278
##########
File path: src/components/Global.vue
##########
@@ -1,12 +1,14 @@
<script>
import axios from 'axios'
+ // const downloadIotdbCli = 'https://github.com/apache/incubator-iotdb';
const downloadIotdbCli = 'https://github.com/apache/incubator-iotdb';
const downloadGrafanaConnector = 'https://github.com/apache/incubator-iotdb';
const downloadHadoopConnector = 'https://github.com/apache/incubator-iotdb';
const downloadSparkConnector = 'https://github.com/apache/incubator-iotdb';
const cheerio = require('cheerio');
+ // const DOC_URL_PREFIX = "https://rhh.666love.cn/incubator-iotdb/";
Review comment:
Remember to remove these comments when submitting PR : )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services