You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by alopresto <gi...@git.apache.org> on 2017/03/04 01:39:39 UTC

[GitHub] nifi pull request #1536: NIFI-3497 ScanAttribute Tagging

Github user alopresto commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1536#discussion_r104273923
  
    --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ScanAttribute.java ---
    @@ -97,13 +107,23 @@
                 .addValidator(StandardValidators.createRegexValidator(0, 1, false))
                 .defaultValue(null)
                 .build();
    +    public static final PropertyDescriptor DICTIONARY_ENTRY_METADATA_DEMARCATOR = new PropertyDescriptor.Builder()
    +            .name("Dictionary Entry Metadata Demarcator")
    --- End diff --
    
    The preferred code style is to use a "machine-readable" (aka no spaces) value for `name` and provide a human-formatted value for `displayName`. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---