You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "feiniaofeiafei (via GitHub)" <gi...@apache.org> on 2024/02/29 09:08:03 UTC
[PR] [Fix](nereids) Only rewrite the slots that appear both in trival-agg func and grouping sets [doris]
feiniaofeiafei opened a new pull request, #31600:
URL: https://github.com/apache/doris/pull/31600
```sql
select sum(col_int_undef_signed + sum(col_int_undef_signed)) over (partition by(sum(col_int_undef_signed))
order by sum(col_int_undef_signed)) from table_10_undef_undef4 group by
grouping sets ((col_text_undef_signed,col_int_undef_signed))
```
in sum(col_int_undef_signed#1 + sum(col_int_undef_signed#2)) , col_int_undef_signed#1 should not be rewritten and col_int_undef_signed#2 should be rewritten. This pr is to fix this problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](nereids) Only rewrite the slots that appear both in trival-agg func and grouping sets [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on PR #31600:
URL: https://github.com/apache/doris/pull/31600#issuecomment-1970794412
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](nereids) Only rewrite the slots that appear both in trival-agg func and grouping sets [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31600:
URL: https://github.com/apache/doris/pull/31600#issuecomment-1970912546
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 9f7b53e91078252a9c84ee65279821833e4836d9 with default session variables
Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select: 18.1 seconds inserted 10000000 Rows, about 552K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](nereids) Only rewrite the slots that appear both in trival-agg func and grouping sets [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31600:
URL: https://github.com/apache/doris/pull/31600#issuecomment-1970706555
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](nereids) Only rewrite the slots that appear both in trival-agg func and grouping sets [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #31600:
URL: https://github.com/apache/doris/pull/31600
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](nereids) Only rewrite the slots that appear both in trival-agg func and grouping sets [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31600:
URL: https://github.com/apache/doris/pull/31600#issuecomment-1970824167
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](nereids) Only rewrite the slots that appear both in trival-agg func and grouping sets [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31600:
URL: https://github.com/apache/doris/pull/31600#issuecomment-1970899115
<details>
<summary>TPC-DS: <b>Total hot run time: 170006 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9f7b53e91078252a9c84ee65279821833e4836d9, data reload: false
query1 923 348 341 341
query2 6528 1811 1747 1747
query3 6709 223 211 211
query4 23244 20582 20611 20582
query5 4212 367 358 358
query6 265 166 170 166
query7 4606 300 306 300
query8 272 193 216 193
query9 8500 2303 2291 2291
query10 415 217 220 217
query11 14577 14223 14225 14223
query12 137 84 85 84
query13 1645 432 459 432
query14 8999 6301 6300 6300
query15 215 176 178 176
query16 7085 261 261 261
query17 1039 522 499 499
query18 1900 268 272 268
query19 202 149 150 149
query20 89 80 88 80
query21 199 122 131 122
query22 4786 4696 4645 4645
query23 30570 29893 29872 29872
query24 11720 3169 3118 3118
query25 667 354 352 352
query26 1812 164 165 164
query27 3050 305 314 305
query28 7032 1853 1871 1853
query29 1185 586 563 563
query30 286 133 149 133
query31 850 684 691 684
query32 96 64 59 59
query33 712 226 230 226
query34 1038 478 503 478
query35 871 767 752 752
query36 988 898 839 839
query37 149 62 64 62
query38 3121 3043 3021 3021
query39 1308 1266 1252 1252
query40 281 105 104 104
query41 40 36 36 36
query42 108 98 102 98
query43 489 436 434 434
query44 1073 713 719 713
query45 191 181 171 171
query46 1051 814 794 794
query47 1534 1444 1505 1444
query48 421 341 348 341
query49 1163 308 300 300
query50 773 380 379 379
query51 4318 4257 4308 4257
query52 102 94 90 90
query53 343 267 266 266
query54 297 222 234 222
query55 85 83 81 81
query56 227 203 213 203
query57 963 903 910 903
query58 216 197 191 191
query59 2139 2058 2130 2058
query60 230 214 213 213
query61 86 93 85 85
query62 615 360 367 360
query63 282 263 258 258
query64 6555 3008 3081 3008
query65 3253 3223 3227 3223
query66 1436 324 325 324
query67 14728 14363 14128 14128
query68 3726 565 571 565
query69 522 387 381 381
query70 1225 1181 1189 1181
query71 328 251 258 251
query72 6015 2846 2689 2689
query73 707 329 325 325
query74 6310 5951 6031 5951
query75 3056 2443 2426 2426
query76 2335 1063 1128 1063
query77 331 233 235 233
query78 8891 8465 8462 8462
query79 2331 523 530 523
query80 1102 361 350 350
query81 499 197 199 197
query82 926 90 85 85
query83 229 124 120 120
query84 283 81 80 80
query85 1425 372 355 355
query86 438 295 297 295
query87 3241 3126 3103 3103
query88 3087 2352 2346 2346
query89 398 347 331 331
query90 1943 175 169 169
query91 163 129 126 126
query92 55 48 50 48
query93 1590 542 528 528
query94 1255 184 184 184
query95 443 337 348 337
query96 578 269 268 268
query97 4251 4096 4181 4096
query98 222 200 190 190
query99 1081 686 697 686
Total cold run time: 263987 ms
Total hot run time: 170006 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](nereids) Only rewrite the slots that appear both in trival-agg func and grouping sets [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31600:
URL: https://github.com/apache/doris/pull/31600#issuecomment-1970907507
<details>
<summary>ClickBench: <b>Total hot run time: 32.24 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9f7b53e91078252a9c84ee65279821833e4836d9, data reload: false
query1 0.04 0.03 0.03
query2 0.07 0.03 0.03
query3 0.23 0.06 0.06
query4 1.66 0.09 0.10
query5 0.52 0.52 0.53
query6 1.28 0.68 0.67
query7 0.02 0.01 0.01
query8 0.03 0.02 0.02
query9 0.55 0.51 0.51
query10 0.57 0.58 0.57
query11 0.13 0.10 0.10
query12 0.13 0.10 0.11
query13 0.62 0.62 0.62
query14 0.78 0.81 0.80
query15 0.85 0.82 0.81
query16 0.37 0.36 0.39
query17 1.00 0.97 1.01
query18 0.25 0.25 0.24
query19 1.77 1.79 1.71
query20 0.02 0.01 0.01
query21 15.40 0.67 0.62
query22 3.37 4.56 2.46
query23 17.43 1.09 1.04
query24 2.16 0.55 0.19
query25 0.28 0.10 0.07
query26 0.16 0.14 0.14
query27 0.04 0.03 0.03
query28 12.25 0.84 0.85
query29 12.73 3.32 3.28
query30 0.59 0.56 0.53
query31 2.78 0.34 0.37
query32 3.35 0.47 0.47
query33 3.21 3.22 3.22
query34 15.35 4.74 4.75
query35 4.75 4.74 4.71
query36 1.12 1.06 1.06
query37 0.06 0.05 0.06
query38 0.04 0.03 0.03
query39 0.02 0.01 0.02
query40 0.17 0.13 0.13
query41 0.07 0.02 0.01
query42 0.02 0.02 0.02
query43 0.03 0.02 0.02
Total cold run time: 106.27 s
Total hot run time: 32.24 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](nereids) Only rewrite the slots that appear both in trival-agg func and grouping sets [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31600:
URL: https://github.com/apache/doris/pull/31600#issuecomment-1970881889
<details>
<summary>TPC-H: <b>Total hot run time: 38630 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9f7b53e91078252a9c84ee65279821833e4836d9, data reload: false
------ Round 1 ----------------------------------
q1 18281 4236 4196 4196
q2 2102 144 139 139
q3 11581 993 966 966
q4 5532 988 994 988
q5 7760 3040 3119 3040
q6 188 131 129 129
q7 1278 811 783 783
q8 10227 1967 2044 1967
q9 7223 7206 6332 6332
q10 8217 2520 2515 2515
q11 424 226 204 204
q12 731 315 316 315
q13 17962 3231 3254 3231
q14 284 243 253 243
q15 531 510 494 494
q16 473 403 428 403
q17 955 886 858 858
q18 6408 6107 6112 6107
q19 1573 1533 1533 1533
q20 484 282 265 265
q21 6326 3641 3628 3628
q22 780 295 294 294
Total cold run time: 109320 ms
Total hot run time: 38630 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4044 4045 4042 4042
q2 301 222 211 211
q3 3010 2957 2945 2945
q4 1856 1810 1832 1810
q5 5121 5086 5150 5086
q6 202 119 117 117
q7 2142 1731 1725 1725
q8 3148 3215 3253 3215
q9 8275 8219 8267 8219
q10 5919 3695 3647 3647
q11 505 430 419 419
q12 696 545 527 527
q13 3764 3094 3062 3062
q14 271 250 273 250
q15 534 498 489 489
q16 526 446 463 446
q17 1714 1693 1702 1693
q18 7802 7583 7388 7388
q19 1666 1647 1654 1647
q20 2119 1901 1896 1896
q21 4841 4659 4687 4659
q22 495 437 438 437
Total cold run time: 58951 ms
Total hot run time: 53930 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](nereids) Only rewrite the slots that appear both in trival-agg func and grouping sets [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31600:
URL: https://github.com/apache/doris/pull/31600#issuecomment-1970824272
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org