You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "sarvekshayr (via GitHub)" <gi...@apache.org> on 2025/09/25 04:20:56 UTC
[PR] HDDS-13617. Avoid immediate ICR for close container [ozone]
sarvekshayr opened a new pull request, #9064:
URL: https://github.com/apache/ozone/pull/9064
## What changes were proposed in this pull request?
SCM sends an Incremental Container Report (ICR) for every close container event, even when there is no actual state change. This results in a large number of ICRs, especially when datanode pipelines become unstable due to factors like other DNs going down, network issues, or the local datanode being overloaded. Each pipeline close triggers close container events for all containers in the pipeline, and these ICRs are retried repeatedly, adding unnecessary load.
To optimise this, we have modified the behaviour so that when there is no state change, the close container report is deferred and sent with the next heartbeat. If there is a state change, the ICR is triggered immediately. This reduces redundant ICRs.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-13617
## How was this patch tested?
Added a unit test - `TestKeyValueHandler#testICRsOnContainerClose`
CI: https://github.com/sarvekshayr/ozone/actions/runs/17974803776
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-13617. Avoid immediate ICR for close container [ozone]
Posted by "sumitagrawl (via GitHub)" <gi...@apache.org>.
sumitagrawl merged PR #9064:
URL: https://github.com/apache/ozone/pull/9064
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-13617. Avoid immediate ICR for close container [ozone]
Posted by "priyeshkaratha (via GitHub)" <gi...@apache.org>.
priyeshkaratha commented on code in PR #9064:
URL: https://github.com/apache/ozone/pull/9064#discussion_r2383785890
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/ozoneimpl/OzoneContainer.java:
##########
@@ -156,6 +156,7 @@ enum InitializingStatus {
* @throws DiskOutOfSpaceException
* @throws IOException
*/
+ @SuppressWarnings("checkstyle:methodlength")
Review Comment:
Instead of suppress warning, can we split the method into multiple methods?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org