You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/10/19 01:29:00 UTC
[jira] [Commented] (BEAM-3076) support TIMESTAMP in BeamRecordType
[ https://issues.apache.org/jira/browse/BEAM-3076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210431#comment-16210431 ]
ASF GitHub Bot commented on BEAM-3076:
--------------------------------------
GitHub user zangshayang1 opened a pull request:
https://github.com/apache/beam/pull/4015
[BEAM-3076] support TIMESTAMP in BeamRecordType
This is to support Timestamp datatype in BeamRecordSqlType.java by introducing TimestampCoder. Previously Timestamp datatype is mapped to Date type.
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zangshayang1/beam BEAM-3076
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/4015.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4015
----
commit d479b3e43c5bbc6fe6dec69a9753e510e94e3fb0
Author: zangshayang1 <za...@hotmail.com>
Date: 2017-10-19T01:08:45Z
This is to support Timestamp datatype in BeamRecordSqlType.java by introducing TimestampCoder. Previously Timestamp datatype is mapped to Date type.
----
> support TIMESTAMP in BeamRecordType
> -----------------------------------
>
> Key: BEAM-3076
> URL: https://issues.apache.org/jira/browse/BEAM-3076
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql
> Reporter: Shayang Zang
> Assignee: Shayang Zang
> Priority: Minor
>
> Timestamp type of data was mapped to Data.class and also sharing DateCoder() during BeamSql execution. We want it to be supported in BeamRecordType as a stand-alone datatype.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)