You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@griffin.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/01/03 08:10:00 UTC

[jira] [Work logged] (GRIFFIN-318) Replace all YYYY with yyyy in all user guides and examples

     [ https://issues.apache.org/jira/browse/GRIFFIN-318?focusedWorklogId=365713&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-365713 ]

ASF GitHub Bot logged work on GRIFFIN-318:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Jan/20 08:09
            Start Date: 03/Jan/20 08:09
    Worklog Time Spent: 10m 
      Work Description: neveljkovic commented on pull request #565: [GRIFFIN-318] Replace all YYYY with yyyy in all user guides and examples
URL: https://github.com/apache/griffin/pull/565
 
 
   https://issues.apache.org/jira/browse/GRIFFIN-318
   Replace YYYY with yyyy and DD with dd
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 365713)
    Remaining Estimate: 0h
            Time Spent: 10m

> Replace all YYYY with yyyy in all user guides and examples
> ----------------------------------------------------------
>
>                 Key: GRIFFIN-318
>                 URL: https://issues.apache.org/jira/browse/GRIFFIN-318
>             Project: Griffin
>          Issue Type: Bug
>            Reporter: Nevena Veljkovic
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> In [https://github.com/apache/griffin/blob/master/griffin-doc/ui/user-guide.md]
> YYYY should be replaced with yyyy
> also DD/MM/YYYY should be replaced with dd/MM/yyyy 
> If anybody uses examples from user guide, she/he will encounter 2020-12-31 issue like I did
>  * Why to replace YYYY: YYYY (week year) is not necessarily equal to yyyy (calendar year)
>  * Why to replace DD and YYYY in DD/MM/YYYY: DD is day of year and YYYY is week year, author probable wanted to use dd (day of month) and yyyy (calendar year)
> Also in [https://github.com/apache/griffin/blob/master/ui/angular/src/app/measure/create-measure/configuration/configuration.component.html]
> dt=#YYYYMMdd# should be replaced with dt=#yyyyMMdd#
>  
> [https://github.com/apache/griffin/blob/master/service/src/main/java/org/apache/griffin/core/util/TimeUtil.java#L138]
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)