[jira] [Commented] (FLINK-4443) Add support in RpcCompletenessTest for inheritance of RpcGateway and RpcEndpoint

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-4443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15430889#comment-15430889 ] 

ASF GitHub Bot commented on FLINK-4443:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2401#discussion_r75690051
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rpc/RpcGateway.java ---
    @@ -28,5 +28,6 @@
     	 *
     	 * @return Fully qualified address under which the associated rpc endpoint is reachable
     	 */
    +	@NativeMethod
     	String getAddress();
    --- End diff --
    
    Can't we simply say that all methods defined in `RpcGateway` are implicitly a *native* method. Then we could save the `@NativeMethod` annotation.


> Add support in RpcCompletenessTest for inheritance of RpcGateway and RpcEndpoint
> --------------------------------------------------------------------------------
>
>                 Key: FLINK-4443
>                 URL: https://issues.apache.org/jira/browse/FLINK-4443
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Coordination
>            Reporter: Wenlong Lyu
>            Assignee: Wenlong Lyu
>
> RpcCompletenessTest needs to support RpcGateway which is composited by some basic functions like the example following:
> {code:java}
> public interface ExecutionStateListener extends RpcGateway {
> 	public void notifyExecutionStateChanges();
> }
> public interface JobStateListener extends RpcGateway {
> 	public void notifyJobStateChanges();
> }
> public interface JobWatcher extends ExecutionStateListener, JobStateListener, RpcGateway {
> }
> public class JobWatcherEndpoint extends RpcEndpoint<JobWatcher> {
> 	protected JobWatcherEndpoint(RpcService rpcService) {
> 		super(rpcService);
> 	}
> 	@RpcMethod
> 	public void notifyExecutionStateChanges() {
> 	}
> 	@RpcMethod
> 	public void notifyJobStateChanges() {
> 	}
> }
> public class AttachedJobClient extends JobWatcherEndpoint {
> 	protected JobClient(RpcService rpcService) {
> 		super(rpcService);
> 	}
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)