You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2021/10/02 12:14:21 UTC

svn commit: r1893810 - /pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/io/RandomAccessReadBuffer.java

Author: tilman
Date: Sat Oct  2 12:14:21 2021
New Revision: 1893810

URL: http://svn.apache.org/viewvc?rev=1893810&view=rev
Log:
PDFBOX-4892: optimize + make field final, as suggested by valerybokov

Modified:
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/io/RandomAccessReadBuffer.java

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/io/RandomAccessReadBuffer.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/io/RandomAccessReadBuffer.java?rev=1893810&r1=1893809&r2=1893810&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/io/RandomAccessReadBuffer.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/io/RandomAccessReadBuffer.java Sat Oct  2 12:14:21 2021
@@ -33,7 +33,7 @@ public class RandomAccessReadBuffer impl
     // use the default chunk size
     private int chunkSize = DEFAULT_CHUNK_SIZE_4KB;
     // list containing all chunks
-    private List<ByteBuffer> bufferList = null;
+    private final List<ByteBuffer> bufferList;
     // current chunk
     private ByteBuffer currentBuffer;
     // current pointer to the whole buffer
@@ -63,7 +63,7 @@ public class RandomAccessReadBuffer impl
         // starting with one chunk
         chunkSize = definedChunkSize;
         currentBuffer = ByteBuffer.allocate(chunkSize);
-        bufferList = new ArrayList<>();
+        bufferList = new ArrayList<>(1);
         bufferList.add(currentBuffer);
     }
 
@@ -137,7 +137,6 @@ public class RandomAccessReadBuffer impl
             bufferList.add(newBuffer);
         }
         currentBuffer = bufferList.get(0);
-        
     }
 
     /**