You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by "Ian Maxon (Code Review)" <do...@asterixdb.incubator.apache.org> on 2016/05/20 02:19:01 UTC
Change in asterixdb[master]: Fix CC Nullpointer when Log Level > FINEST
Ian Maxon has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/870
Change subject: Fix CC Nullpointer when Log Level > FINEST
......................................................................
Fix CC Nullpointer when Log Level > FINEST
The Hyracks CC would nullpoint on startup if the log level was
greater than FINEST. Seems to be a concurrency issue related to
initialization of an AtomicInteger. This fixes that.
Change-Id: I720eca41fac312fc6cbdbb880162a5bc8b0357dc
---
M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/work/WorkQueue.java
1 file changed, 2 insertions(+), 4 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/70/870/1
diff --git a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/work/WorkQueue.java b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/work/WorkQueue.java
index 7786db7..3a34a07 100644
--- a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/work/WorkQueue.java
+++ b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/work/WorkQueue.java
@@ -48,10 +48,8 @@
thread = new WorkerThread();
stopSemaphore = new Semaphore(1);
stopped = true;
- if (LOGGER.isLoggable(COUNT_LOGGING_LEVEL)) {
- enqueueCount = new AtomicInteger(0);
- dequeueCount = new AtomicInteger(0);
- }
+ enqueueCount = new AtomicInteger(0);
+ dequeueCount = new AtomicInteger(0);
}
public void start() throws HyracksException {
--
To view, visit https://asterix-gerrit.ics.uci.edu/870
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I720eca41fac312fc6cbdbb880162a5bc8b0357dc
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <im...@apache.org>
Change in asterixdb[master]: ASTERIXDB-1460: Fix log level crashing CC on start
Posted by "Murtadha Hubail (Code Review)" <do...@asterixdb.incubator.apache.org>.
Murtadha Hubail has posted comments on this change.
Change subject: ASTERIXDB-1460: Fix log level crashing CC on start
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://asterix-gerrit.ics.uci.edu/870
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I720eca41fac312fc6cbdbb880162a5bc8b0357dc
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: Fix CC Nullpointer when Log Level > FINEST
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Fix CC Nullpointer when Log Level > FINEST
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1423/
--
To view, visit https://asterix-gerrit.ics.uci.edu/870
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I720eca41fac312fc6cbdbb880162a5bc8b0357dc
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: Fix CC Nullpointer when Log Level > FINEST
Posted by "Ian Maxon (Code Review)" <do...@asterixdb.incubator.apache.org>.
Hello Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/870
to look at the new patch set (#2).
Change subject: Fix CC Nullpointer when Log Level > FINEST
......................................................................
Fix CC Nullpointer when Log Level > FINEST
The Hyracks CC would nullpoint on startup if the log level was
greater than FINEST. Seems to be a concurrency issue related to
initialization of an AtomicInteger. This fixes that.
Change-Id: I720eca41fac312fc6cbdbb880162a5bc8b0357dc
---
M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/work/WorkQueue.java
1 file changed, 2 insertions(+), 4 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/70/870/2
--
To view, visit https://asterix-gerrit.ics.uci.edu/870
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I720eca41fac312fc6cbdbb880162a5bc8b0357dc
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Change in asterixdb[master]: ASTERIXDB-1460: Fix log level crashing CC on start
Posted by "Ian Maxon (Code Review)" <do...@asterixdb.incubator.apache.org>.
Ian Maxon has submitted this change and it was merged.
Change subject: ASTERIXDB-1460: Fix log level crashing CC on start
......................................................................
ASTERIXDB-1460: Fix log level crashing CC on start
The Hyracks CC would nullpoint on startup if the log level was
greater than FINEST. This works around the core issue that's in
ASTERIXDB-1460 since in this instance the way the log level was used
would cause the CC to fail on startup where the log level was
equal to or greater than FINEST.
Change-Id: I720eca41fac312fc6cbdbb880162a5bc8b0357dc
Reviewed-on: https://asterix-gerrit.ics.uci.edu/870
Reviewed-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
Reviewed-by: Murtadha Hubail <hu...@gmail.com>
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
---
M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/work/WorkQueue.java
1 file changed, 8 insertions(+), 7 deletions(-)
Approvals:
Murtadha Hubail: Looks good to me, approved
Jenkins: Looks good to me, but someone else must approve; Verified
diff --git a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/work/WorkQueue.java b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/work/WorkQueue.java
index 7786db7..1f61543 100644
--- a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/work/WorkQueue.java
+++ b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/work/WorkQueue.java
@@ -28,7 +28,8 @@
public class WorkQueue {
private static final Logger LOGGER = Logger.getLogger(WorkQueue.class.getName());
- private static final Level COUNT_LOGGING_LEVEL = Level.FINEST;
+ //to be fixed when application vs. hyracks log level issues are sorted
+ private static final boolean DEBUG = false;
private final LinkedBlockingQueue<AbstractWork> queue;
private final WorkerThread thread;
@@ -48,7 +49,7 @@
thread = new WorkerThread();
stopSemaphore = new Semaphore(1);
stopped = true;
- if (LOGGER.isLoggable(COUNT_LOGGING_LEVEL)) {
+ if(DEBUG) {
enqueueCount = new AtomicInteger(0);
dequeueCount = new AtomicInteger(0);
}
@@ -60,7 +61,7 @@
} catch (InterruptedException e) {
throw new HyracksException(e);
}
- if (LOGGER.isLoggable(COUNT_LOGGING_LEVEL)) {
+ if (DEBUG) {
enqueueCount.set(0);
dequeueCount.set(0);
}
@@ -85,8 +86,8 @@
}
public void schedule(AbstractWork event) {
- if (LOGGER.isLoggable(COUNT_LOGGING_LEVEL)) {
- LOGGER.log(COUNT_LOGGING_LEVEL, "Enqueue (" + hashCode() + "): " + enqueueCount.incrementAndGet());
+ if (DEBUG) {
+ LOGGER.log(Level.FINEST, "Enqueue (" + hashCode() + "): " + enqueueCount.incrementAndGet());
}
if (LOGGER.isLoggable(Level.FINER)) {
LOGGER.finer("Scheduling: " + event);
@@ -120,8 +121,8 @@
} catch (InterruptedException e) {
continue;
}
- if (LOGGER.isLoggable(COUNT_LOGGING_LEVEL)) {
- LOGGER.log(COUNT_LOGGING_LEVEL,
+ if (DEBUG) {
+ LOGGER.log(Level.FINEST,
"Dequeue (" + WorkQueue.this.hashCode() + "): " + dequeueCount.incrementAndGet() + "/"
+ enqueueCount);
}
--
To view, visit https://asterix-gerrit.ics.uci.edu/870
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I720eca41fac312fc6cbdbb880162a5bc8b0357dc
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Change in asterixdb[master]: Fix CC Nullpointer when Log Level > FINEST
Posted by "Murtadha Hubail (Code Review)" <do...@asterixdb.incubator.apache.org>.
Murtadha Hubail has posted comments on this change.
Change subject: Fix CC Nullpointer when Log Level > FINEST
......................................................................
Patch Set 2:
The problem here is that the logger level is not set to the value in the configuration until startApplication() is called. So, during WorkQueue initialization the level is the default level value (INFO) which prevents the AtomicIntegers from being initialized. While fixing this might need discussion, I don't think it is a good idea to base any operation, except logging messages, on the log level. I suggest you replace COUNT_LOGGING_LEVEL by a static boolean DEBUG and all (LOGGER.isLoggable(COUNT_LOGGING_LEVEL) by if(DEBUG). When the global log level issue is resolved, we can simply initialize DEBUG value based on the log level.
I will open a JIRA issue to capture the logging level initialization problem.
--
To view, visit https://asterix-gerrit.ics.uci.edu/870
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I720eca41fac312fc6cbdbb880162a5bc8b0357dc
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: Fix CC Nullpointer when Log Level > FINEST
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Fix CC Nullpointer when Log Level > FINEST
......................................................................
Patch Set 2:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1440/
--
To view, visit https://asterix-gerrit.ics.uci.edu/870
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I720eca41fac312fc6cbdbb880162a5bc8b0357dc
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: Fix CC nullpointer when Log Level > FINEST
Posted by "Ian Maxon (Code Review)" <do...@asterixdb.incubator.apache.org>.
Hello Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/870
to look at the new patch set (#3).
Change subject: Fix CC nullpointer when Log Level > FINEST
......................................................................
Fix CC nullpointer when Log Level > FINEST
The Hyracks CC would nullpoint on startup if the log level was
greater than FINEST. Seems to be a concurrency issue related to
initialization of an AtomicInteger. This fixes that.
Change-Id: I720eca41fac312fc6cbdbb880162a5bc8b0357dc
---
M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/work/WorkQueue.java
1 file changed, 8 insertions(+), 7 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/70/870/3
--
To view, visit https://asterix-gerrit.ics.uci.edu/870
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I720eca41fac312fc6cbdbb880162a5bc8b0357dc
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Change in asterixdb[master]: Fix CC nullpointer when Log Level > FINEST
Posted by "Murtadha Hubail (Code Review)" <do...@asterixdb.incubator.apache.org>.
Murtadha Hubail has posted comments on this change.
Change subject: Fix CC nullpointer when Log Level > FINEST
......................................................................
Patch Set 3:
(1 comment)
https://asterix-gerrit.ics.uci.edu/#/c/870/3/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/work/WorkQueue.java
File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/work/WorkQueue.java:
Line 32: private static boolean DEBUG = false;
Please make DEBUG final for now so that the compiler can get rid of the code during compilation. You may reference the JIRA issue (ASTERIXDB-1460) in the comment.
--
To view, visit https://asterix-gerrit.ics.uci.edu/870
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I720eca41fac312fc6cbdbb880162a5bc8b0357dc
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-HasComments: Yes
Change in asterixdb[master]: ASTERIXDB-1460: Fix log level crashing CC on start
Posted by "Ian Maxon (Code Review)" <do...@asterixdb.incubator.apache.org>.
Hello Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/870
to look at the new patch set (#4).
Change subject: ASTERIXDB-1460: Fix log level crashing CC on start
......................................................................
ASTERIXDB-1460: Fix log level crashing CC on start
The Hyracks CC would nullpoint on startup if the log level was
greater than FINEST. This works around the core issue that's in
ASTERIXDB-1460 since in this instance the way the log level was used
would cause the CC to fail on startup where the log level was
equal to or greater than FINEST.
Change-Id: I720eca41fac312fc6cbdbb880162a5bc8b0357dc
---
M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/work/WorkQueue.java
1 file changed, 8 insertions(+), 7 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/70/870/4
--
To view, visit https://asterix-gerrit.ics.uci.edu/870
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I720eca41fac312fc6cbdbb880162a5bc8b0357dc
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Change in asterixdb[master]: Fix CC nullpointer when Log Level > FINEST
Posted by "Ian Maxon (Code Review)" <do...@asterixdb.incubator.apache.org>.
Ian Maxon has posted comments on this change.
Change subject: Fix CC nullpointer when Log Level > FINEST
......................................................................
Patch Set 3:
I guess the other correct thing in this case would be to determine whether or not the log level is high enough in the constructor rather than assuming the log level never changes during runtime.
--
To view, visit https://asterix-gerrit.ics.uci.edu/870
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I720eca41fac312fc6cbdbb880162a5bc8b0357dc
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1460: Fix log level crashing CC on start
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1460: Fix log level crashing CC on start
......................................................................
Patch Set 4:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1454/
--
To view, visit https://asterix-gerrit.ics.uci.edu/870
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I720eca41fac312fc6cbdbb880162a5bc8b0357dc
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: Fix CC nullpointer when Log Level > FINEST
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Fix CC nullpointer when Log Level > FINEST
......................................................................
Patch Set 3:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1449/
--
To view, visit https://asterix-gerrit.ics.uci.edu/870
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I720eca41fac312fc6cbdbb880162a5bc8b0357dc
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-HasComments: No