You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "xiangfu0 (via GitHub)" <gi...@apache.org> on 2023/02/17 20:28:32 UTC
[GitHub] [pinot] xiangfu0 commented on a diff in pull request #10294: [multistage] support SEMI/ANTI join
xiangfu0 commented on code in PR #10294:
URL: https://github.com/apache/pinot/pull/10294#discussion_r1110325438
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/HashJoinOperator.java:
##########
@@ -101,7 +101,7 @@ public HashJoinOperator(MultiStageOperator leftTableOperator, MultiStageOperator
Preconditions.checkState(_leftRowSize > 0, "leftRowSize has to be greater than zero:" + _leftRowSize);
_resultSchema = node.getDataSchema();
_resultRowSize = _resultSchema.size();
- Preconditions.checkState(_resultRowSize > _leftRowSize,
+ Preconditions.checkState(_resultRowSize >= _leftRowSize,
"Result row size" + _leftRowSize + " has to be greater than left row size:" + _leftRowSize);
Review Comment:
nit: greater than or equal to
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org