You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Noble Paul (JIRA)" <ji...@apache.org> on 2010/01/04 13:19:54 UTC
[jira] Created: (SOLR-1696) Deprecate old syntax and
move configuration to HighlightComponent
Deprecate old <highlighting> syntax and move configuration to HighlightComponent
--------------------------------------------------------------------------------
Key: SOLR-1696
URL: https://issues.apache.org/jira/browse/SOLR-1696
Project: Solr
Issue Type: Improvement
Components: highlighter
Reporter: Noble Paul
Fix For: 1.5
There is no reason why we should have a custom syntax for highlighter configuration.
It can be treated like any other SearchComponent and all the configuration can go in there.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SOLR-1696) Deprecate old syntax
and move configuration to HighlightComponent
Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Noble Paul resolved SOLR-1696.
------------------------------
Resolution: Fixed
committed r899572
> Deprecate old <highlighting> syntax and move configuration to HighlightComponent
> --------------------------------------------------------------------------------
>
> Key: SOLR-1696
> URL: https://issues.apache.org/jira/browse/SOLR-1696
> Project: Solr
> Issue Type: Improvement
> Components: highlighter
> Reporter: Noble Paul
> Assignee: Noble Paul
> Fix For: 1.5
>
> Attachments: SOLR-1696.patch, SOLR-1696.patch
>
>
> There is no reason why we should have a custom syntax for highlighter configuration.
> It can be treated like any other SearchComponent and all the configuration can go in there.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1696) Deprecate old syntax
and move configuration to HighlightComponent
Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12796167#action_12796167 ]
Noble Paul commented on SOLR-1696:
----------------------------------
The new syntax can be as follows
{code:xml}
<searchComponent class="solr.HighLightComponent">
<highlighting class="DefaultSolrHighlighter">
<!-- Configure the standard fragmenter -->
<!-- This could most likely be commented out in the "default" case -->
<fragmenter name="gap" class="org.apache.solr.highlight.GapFragmenter" default="true">
<lst name="defaults">
<int name="hl.fragsize">100</int>
</lst>
</fragmenter>
<!-- A regular-expression-based fragmenter (f.i., for sentence extraction) -->
<fragmenter name="regex" class="org.apache.solr.highlight.RegexFragmenter">
<lst name="defaults">
<!-- slightly smaller fragsizes work better because of slop -->
<int name="hl.fragsize">70</int>
<!-- allow 50% slop on fragment sizes -->
<float name="hl.regex.slop">0.5</float>
<!-- a basic sentence pattern -->
<str name="hl.regex.pattern">[-\w ,/\n\"']{20,200}</str>
</lst>
</fragmenter>
<!-- Configure the standard formatter -->
<formatter name="html" class="org.apache.solr.highlight.HtmlFormatter" default="true">
<lst name="defaults">
<str name="hl.simple.pre"><![CDATA[<em>]]></str>
<str name="hl.simple.post"><![CDATA[</em>]]></str>
</lst>
</formatter>
</highlighting>
</searchComponent>
{code}
This way SolrCore can be totally agnostic of highlighter
> Deprecate old <highlighting> syntax and move configuration to HighlightComponent
> --------------------------------------------------------------------------------
>
> Key: SOLR-1696
> URL: https://issues.apache.org/jira/browse/SOLR-1696
> Project: Solr
> Issue Type: Improvement
> Components: highlighter
> Reporter: Noble Paul
> Fix For: 1.5
>
>
> There is no reason why we should have a custom syntax for highlighter configuration.
> It can be treated like any other SearchComponent and all the configuration can go in there.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1696) Deprecate old syntax
and move configuration to HighlightComponent
Posted by "Koji Sekiguchi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12797841#action_12797841 ]
Koji Sekiguchi commented on SOLR-1696:
--------------------------------------
Noble, thank you for opening this and attaching the patch! Are you planning to commit this shortly? because I'm ready to commit SOLR-1268 that is using old style config. If you commit it, I'll rewrite SOLR-1268. Or I can assign SOLR-1696 to me.
> Deprecate old <highlighting> syntax and move configuration to HighlightComponent
> --------------------------------------------------------------------------------
>
> Key: SOLR-1696
> URL: https://issues.apache.org/jira/browse/SOLR-1696
> Project: Solr
> Issue Type: Improvement
> Components: highlighter
> Reporter: Noble Paul
> Fix For: 1.5
>
> Attachments: SOLR-1696.patch
>
>
> There is no reason why we should have a custom syntax for highlighter configuration.
> It can be treated like any other SearchComponent and all the configuration can go in there.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1696) Deprecate old syntax and
move configuration to HighlightComponent
Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Noble Paul updated SOLR-1696:
-----------------------------
Attachment: SOLR-1696.patch
The old syntax is deprecated and all the code moves in into HighlightComponent. SolrCore is agnostic of loading and managing HighlightComponent
> Deprecate old <highlighting> syntax and move configuration to HighlightComponent
> --------------------------------------------------------------------------------
>
> Key: SOLR-1696
> URL: https://issues.apache.org/jira/browse/SOLR-1696
> Project: Solr
> Issue Type: Improvement
> Components: highlighter
> Reporter: Noble Paul
> Fix For: 1.5
>
> Attachments: SOLR-1696.patch
>
>
> There is no reason why we should have a custom syntax for highlighter configuration.
> It can be treated like any other SearchComponent and all the configuration can go in there.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (SOLR-1696) Deprecate old
syntax and move configuration to HighlightComponent
Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12796167#action_12796167 ]
Noble Paul edited comment on SOLR-1696 at 1/5/10 8:40 AM:
----------------------------------------------------------
The new syntax can be as follows
{code:xml}
<searchComponent class="solr.HighLightComponent" name="highlight">
<highlighting class="DefaultSolrHighlighter">
<!-- Configure the standard fragmenter -->
<!-- This could most likely be commented out in the "default" case -->
<fragmenter name="gap" class="org.apache.solr.highlight.GapFragmenter" default="true">
<lst name="defaults">
<int name="hl.fragsize">100</int>
</lst>
</fragmenter>
<!-- A regular-expression-based fragmenter (f.i., for sentence extraction) -->
<fragmenter name="regex" class="org.apache.solr.highlight.RegexFragmenter">
<lst name="defaults">
<!-- slightly smaller fragsizes work better because of slop -->
<int name="hl.fragsize">70</int>
<!-- allow 50% slop on fragment sizes -->
<float name="hl.regex.slop">0.5</float>
<!-- a basic sentence pattern -->
<str name="hl.regex.pattern">[-\w ,/\n\"']{20,200}</str>
</lst>
</fragmenter>
<!-- Configure the standard formatter -->
<formatter name="html" class="org.apache.solr.highlight.HtmlFormatter" default="true">
<lst name="defaults">
<str name="hl.simple.pre"><![CDATA[<em>]]></str>
<str name="hl.simple.post"><![CDATA[</em>]]></str>
</lst>
</formatter>
</highlighting>
</searchComponent>
{code}
This way SolrCore can be totally agnostic of highlighter
was (Author: noble.paul):
The new syntax can be as follows
{code:xml}
<searchComponent class="solr.HighLightComponent">
<highlighting class="DefaultSolrHighlighter">
<!-- Configure the standard fragmenter -->
<!-- This could most likely be commented out in the "default" case -->
<fragmenter name="gap" class="org.apache.solr.highlight.GapFragmenter" default="true">
<lst name="defaults">
<int name="hl.fragsize">100</int>
</lst>
</fragmenter>
<!-- A regular-expression-based fragmenter (f.i., for sentence extraction) -->
<fragmenter name="regex" class="org.apache.solr.highlight.RegexFragmenter">
<lst name="defaults">
<!-- slightly smaller fragsizes work better because of slop -->
<int name="hl.fragsize">70</int>
<!-- allow 50% slop on fragment sizes -->
<float name="hl.regex.slop">0.5</float>
<!-- a basic sentence pattern -->
<str name="hl.regex.pattern">[-\w ,/\n\"']{20,200}</str>
</lst>
</fragmenter>
<!-- Configure the standard formatter -->
<formatter name="html" class="org.apache.solr.highlight.HtmlFormatter" default="true">
<lst name="defaults">
<str name="hl.simple.pre"><![CDATA[<em>]]></str>
<str name="hl.simple.post"><![CDATA[</em>]]></str>
</lst>
</formatter>
</highlighting>
</searchComponent>
{code}
This way SolrCore can be totally agnostic of highlighter
> Deprecate old <highlighting> syntax and move configuration to HighlightComponent
> --------------------------------------------------------------------------------
>
> Key: SOLR-1696
> URL: https://issues.apache.org/jira/browse/SOLR-1696
> Project: Solr
> Issue Type: Improvement
> Components: highlighter
> Reporter: Noble Paul
> Fix For: 1.5
>
>
> There is no reason why we should have a custom syntax for highlighter configuration.
> It can be treated like any other SearchComponent and all the configuration can go in there.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1696) Deprecate old syntax
and move configuration to HighlightComponent
Posted by "Koji Sekiguchi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12798312#action_12798312 ]
Koji Sekiguchi commented on SOLR-1696:
--------------------------------------
I've just committed SOLR-1268. Now I'm trying to contribute a patch for this to sync with trunk...
> Deprecate old <highlighting> syntax and move configuration to HighlightComponent
> --------------------------------------------------------------------------------
>
> Key: SOLR-1696
> URL: https://issues.apache.org/jira/browse/SOLR-1696
> Project: Solr
> Issue Type: Improvement
> Components: highlighter
> Reporter: Noble Paul
> Fix For: 1.5
>
> Attachments: SOLR-1696.patch
>
>
> There is no reason why we should have a custom syntax for highlighter configuration.
> It can be treated like any other SearchComponent and all the configuration can go in there.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1696) Deprecate old syntax and
move configuration to HighlightComponent
Posted by "Koji Sekiguchi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Koji Sekiguchi updated SOLR-1696:
---------------------------------
Attachment: SOLR-1696.patch
A new patch attached. Just to sync with trunk plus warning log when deprecated syntax is found (the idea Chris mentioned above).
> Deprecate old <highlighting> syntax and move configuration to HighlightComponent
> --------------------------------------------------------------------------------
>
> Key: SOLR-1696
> URL: https://issues.apache.org/jira/browse/SOLR-1696
> Project: Solr
> Issue Type: Improvement
> Components: highlighter
> Reporter: Noble Paul
> Fix For: 1.5
>
> Attachments: SOLR-1696.patch, SOLR-1696.patch
>
>
> There is no reason why we should have a custom syntax for highlighter configuration.
> It can be treated like any other SearchComponent and all the configuration can go in there.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (SOLR-1696) Deprecate old syntax
and move configuration to HighlightComponent
Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Noble Paul reassigned SOLR-1696:
--------------------------------
Assignee: Noble Paul
> Deprecate old <highlighting> syntax and move configuration to HighlightComponent
> --------------------------------------------------------------------------------
>
> Key: SOLR-1696
> URL: https://issues.apache.org/jira/browse/SOLR-1696
> Project: Solr
> Issue Type: Improvement
> Components: highlighter
> Reporter: Noble Paul
> Assignee: Noble Paul
> Fix For: 1.5
>
> Attachments: SOLR-1696.patch, SOLR-1696.patch
>
>
> There is no reason why we should have a custom syntax for highlighter configuration.
> It can be treated like any other SearchComponent and all the configuration can go in there.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1696) Deprecate old syntax
and move configuration to HighlightComponent
Posted by "Chris Male (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12796584#action_12796584 ]
Chris Male commented on SOLR-1696:
----------------------------------
Are you planning on logging a warning if they continue to use the deprecated syntax?
> Deprecate old <highlighting> syntax and move configuration to HighlightComponent
> --------------------------------------------------------------------------------
>
> Key: SOLR-1696
> URL: https://issues.apache.org/jira/browse/SOLR-1696
> Project: Solr
> Issue Type: Improvement
> Components: highlighter
> Reporter: Noble Paul
> Fix For: 1.5
>
> Attachments: SOLR-1696.patch
>
>
> There is no reason why we should have a custom syntax for highlighter configuration.
> It can be treated like any other SearchComponent and all the configuration can go in there.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.