[GitHub] [flink] alpreu commented on a change in pull request #17819: [FLINK-15816][k8s] Prevent labels using kubernetes.cluster-id to exceed the limit of 63 characters

[GitBox <gi...@apache.org>]

alpreu commented on a change in pull request #17819:
URL: https://github.com/apache/flink/pull/17819#discussion_r780321225



##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/configuration/KubernetesConfigOptions.java
##########
@@ -220,7 +220,7 @@
                     .withDescription(
                             Description.builder()
                                     .text(
-                                            "The cluster-id, which should be no more than 45 characters, is used for identifying a unique Flink cluster. "
+                                            "The cluster-id, which should be no more than 40 characters, is used for identifying a unique Flink cluster. "

Review comment:
       Yes, it changed back to the original value. The reason is that the 40 was derived from the `"-resourcemanager-leader"` in `KubernetesHaServices`. In that class only configmap names are generated, for which the 63 character limit does not apply. I don't know if it makes sense to move this generation also into `KubernetesLabel`.  Especially because the JobManager one does contain the `JobID` which would restrict the clusterId length extremely.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org