You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/02/09 20:19:34 UTC
[GitHub] [maven-invoker-plugin] slawekjaranowski opened a new pull request #36: [MINVOKER-258] normalize the line endings code to LF
slawekjaranowski opened a new pull request #36:
URL: https://github.com/apache/maven-invoker-plugin/pull/36
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-invoker-plugin] slawekjaranowski commented on pull request #36: [MINVOKER-258] normalize the line endings code to LF
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on pull request #36:
URL: https://github.com/apache/maven-invoker-plugin/pull/36#issuecomment-776254578
`.gitattribute` we use when some file should has the same line end code on all operating system.
For standard files we should have one and the same line end code in all files in repo and allow users to setup local environment by `core.autocrlf`
Now in repo we have mixed line end code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-invoker-plugin] michael-o commented on pull request #36: [MINVOKER-258] normalize the line endings code to LF
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #36:
URL: https://github.com/apache/maven-invoker-plugin/pull/36#issuecomment-873375136
Alright, I will try to review this weekend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-invoker-plugin] slawekjaranowski commented on pull request #36: [MINVOKER-258] normalize the line endings code to LF
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on pull request #36:
URL: https://github.com/apache/maven-invoker-plugin/pull/36#issuecomment-873373801
Exactly for this is PR ...
in repository we should have every file with the same line encoding and conversion should be done on client site according to `core.autocrlf` settings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-invoker-plugin] pzygielo commented on a change in pull request #36: [MINVOKER-258] normalize the line endings code to LF
Posted by GitBox <gi...@apache.org>.
pzygielo commented on a change in pull request #36:
URL: https://github.com/apache/maven-invoker-plugin/pull/36#discussion_r573471527
##########
File path: src/main/resources/invoker-report_fr.properties
##########
@@ -15,21 +15,21 @@
# specific language governing permissions and limitations
# under the License.
-report.invoker.result.description = R�sultat des invocations de Maven
-report.invoker.result.name = Invoker R�sultat de builds
+report.invoker.result.description = R�sultat des invocations de Maven
Review comment:
I don't know any French, but in my diff view this `é` -> `�` doesn't look right.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-invoker-plugin] slawekjaranowski commented on pull request #36: [MINVOKER-258] normalize the line endings code to LF
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on pull request #36:
URL: https://github.com/apache/maven-invoker-plugin/pull/36#issuecomment-873139090
What we do with this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-invoker-plugin] michael-o commented on pull request #36: [MINVOKER-258] normalize the line endings code to LF
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #36:
URL: https://github.com/apache/maven-invoker-plugin/pull/36#issuecomment-873157761
I need to look at this. I would prefer autodetection and line endings according to the OS by Git unless the fileformat requires LF.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-invoker-plugin] michael-o commented on pull request #36: [MINVOKER-258] normalize the line endings code to LF
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #36:
URL: https://github.com/apache/maven-invoker-plugin/pull/36#issuecomment-776226045
Why not use `.gitattributes` for that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-invoker-plugin] slawekjaranowski commented on a change in pull request #36: [MINVOKER-258] normalize the line endings code to LF
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on a change in pull request #36:
URL: https://github.com/apache/maven-invoker-plugin/pull/36#discussion_r573516810
##########
File path: src/main/resources/invoker-report_fr.properties
##########
@@ -15,21 +15,21 @@
# specific language governing permissions and limitations
# under the License.
-report.invoker.result.description = R�sultat des invocations de Maven
-report.invoker.result.name = Invoker R�sultat de builds
+report.invoker.result.description = R�sultat des invocations de Maven
Review comment:
@pzygielo you right - the file is encoded by iso-8859-2, probably special language chars should be escaped by unicode \uxxxx - but it is another issue
I removed this file from changeset
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-invoker-plugin] asfgit closed pull request #36: [MINVOKER-258] normalize the line endings code to LF
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #36:
URL: https://github.com/apache/maven-invoker-plugin/pull/36
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org