[GitHub] [doris] github-actions[bot] commented on a diff in pull request #15317: [enhancement](histogram) optimise aggregate function histogram

[GitBox <gi...@apache.org>]

github-actions[bot] commented on code in PR #15317:
URL: https://github.com/apache/doris/pull/15317#discussion_r1056120029


##########
be/test/vec/aggregate_functions/agg_histogram_test.cpp:
##########
@@ -80,8 +116,8 @@ class VAggHistogramTest : public testing::Test {
         std::unique_ptr<char[]> memory(new char[agg_function->size_of_data()]);
         AggregateDataPtr place = memory.get();
         agg_function->create(place);
-
-        agg_histogram_add_elements<DataType>(agg_function, place, input_nums);
+        agg_histogram_add_elements<DataType>(agg_function, place, input_rows, sample_rate,
+                                             max_bucket_num);
 
         ColumnString buf;

Review Comment:
   warning: calling a private constructor of class 'doris::vectorized::ColumnString' [clang-diagnostic-error]
   ```cpp
           ColumnString buf;
                        ^
   ```
   **be/src/vec/columns/column_string.h:65:** declared private here
   ```cpp
       ColumnString() = default;
       ^
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org